IDBObserver: Lifetime Management: Adding Observer

content/browser/indexed_db/indexed_db_database_unittest.cc

Index: content/browser/indexed_db/indexed_db_database_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc
index f01c413e100cf59a30ae49b0656fbc86eee55a86..b9f137ea94cfbe2503d31626c26ebf705af70dec 100644
--- a/content/browser/indexed_db/indexed_db_database_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc
@@ -238,9 +238,12 @@ class IndexedDBDatabaseOperationTest : public testing::Test {
         IndexedDBDatabaseMetadata::DEFAULT_VERSION));
     EXPECT_EQ(IndexedDBDatabaseMetadata::NO_VERSION, db_->metadata().version);
 
+    std::unique_ptr<IndexedDBConnection> connection_(

[cmumford, 2016/07/01 18:35:00]

connection_ is a local variable (not a class member), so shouldn't have a
trailing underscore.

Also, once this method, Setup(), goes out of scope transaction_ will have a null
WeakPtr to a connection. Do you want to make connection a member of this class?

[palakj1, 2016/07/02 00:48:13]

Thanks for pointing that out. Turned connection to a member.

+        new IndexedDBConnection(db_, callbacks_));
     transaction_ = IndexedDBClassFactory::Get()->CreateIndexedDBTransaction(
-        transaction_id, callbacks_, std::set<int64_t>() /*scope*/,
-        blink::WebIDBTransactionModeVersionChange, db_.get(),
+        transaction_id, connection_->GetWeakPtr(),
+        std::set<int64_t>() /*scope*/,
+        blink::WebIDBTransactionModeVersionChange,
         new IndexedDBFakeBackingStore::FakeTransaction(commit_success_));
     db_->TransactionCreated(transaction_.get());