third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h - Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer

Unified Diff: third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Units tests added Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/indexed_db/indexed_db_dispatcher.cc ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBObserver.idl ('k') | third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h

diff --git a/third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h b/third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h

index 30445548c8452630d133ca465913b66d74b1a0b5..d9296ce3fb10c885ea18d9a96b302dd18f6c2fdc 100644

--- a/third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h

+++ b/third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h

@@ -9,6 +9,7 @@

#include "modules/indexeddb/IDBKeyRange.h"

#include "public/platform/modules/indexeddb/WebIDBDatabase.h"

#include "public/platform/modules/indexeddb/WebIDBKeyRange.h"

+#include "public/platform/modules/indexeddb/WebIDBObserver.h"

#include <gmock/gmock.h>

#include <memory>

@@ -29,6 +30,11 @@ public:

MOCK_METHOD1(commit, void(long long transactionId));

MOCK_METHOD7(createIndex, void(long long transactionId, long long objectStoreId, long long indexId, const WebString& name, const WebIDBKeyPath&, bool unique, bool multiEntry));

MOCK_METHOD3(deleteIndex, void(long long transactionId, long long objectStoreId, long long indexId));

+ // Gmock does not support movable type, so cannot use MOCK_METHOD for addObserver.

Marijn Kruisselbrink 2016/06/30 00:17:25 You could mention https://github.com/google/google

palakj1 2016/06/30 01:07:04 Thanks. I'll do that.

+ int32_t addObserver(std::unique_ptr<WebIDBObserver>, long long transactionId) { return -1; }

+ MOCK_CONST_METHOD1(containsObserverId, bool(int32_t id));

+ MOCK_METHOD1(removeObservers, void(const std::vector<int32_t>& observerIdsToRemove));

MOCK_METHOD6(get, void(long long transactionId, long long objectStoreId, long long indexId, const WebIDBKeyRange&, bool keyOnly, WebIDBCallbacks*));

MOCK_METHOD7(getAll, void(long long transactionId, long long objectStoreId, long long indexId, const WebIDBKeyRange&, long long maxCount, bool keyOnly, WebIDBCallbacks*));

MOCK_METHOD9(put, void(long long transactionId, long long objectStoreId, const WebData& value, const WebVector<WebBlobInfo>&, const WebIDBKey&, WebIDBPutMode, WebIDBCallbacks*, const WebVector<long long>& indexIds, const WebVector<WebIndexKeys>&));