IDBObserver: Lifetime Management: Adding Observer

content/browser/indexed_db/indexed_db_database_unittest.cc

Index: content/browser/indexed_db/indexed_db_database_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc
index f01c413e100cf59a30ae49b0656fbc86eee55a86..b53f5d57bb77f6828aa4a8d1311a1c63cb5fca23 100644
--- a/content/browser/indexed_db/indexed_db_database_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc
@@ -238,9 +238,10 @@ class IndexedDBDatabaseOperationTest : public testing::Test {
         IndexedDBDatabaseMetadata::DEFAULT_VERSION));
     EXPECT_EQ(IndexedDBDatabaseMetadata::NO_VERSION, db_->metadata().version);
 
+    connection_ = new IndexedDBConnection(db_, callbacks_);
     transaction_ = IndexedDBClassFactory::Get()->CreateIndexedDBTransaction(
-        transaction_id, callbacks_, std::set<int64_t>() /*scope*/,
-        blink::WebIDBTransactionModeVersionChange, db_.get(),
+        transaction_id, connection_, std::set<int64_t>() /*scope*/,
+        blink::WebIDBTransactionModeVersionChange,
         new IndexedDBFakeBackingStore::FakeTransaction(commit_success_));
     db_->TransactionCreated(transaction_.get());
 
@@ -258,6 +259,7 @@ class IndexedDBDatabaseOperationTest : public testing::Test {
   scoped_refptr<MockIndexedDBCallbacks> request_;
   scoped_refptr<MockIndexedDBDatabaseCallbacks> callbacks_;
   scoped_refptr<IndexedDBTransaction> transaction_;
+  IndexedDBConnection* connection_;

[Marijn Kruisselbrink, 2016/06/30 00:17:25]

this should probably be a unique_ptr<IndexedDBConnection> to make sure the
connection actually gets cleaned up at the end of a test?

[palakj1, 2016/06/30 01:07:04]

Done.

 
   leveldb::Status commit_success_;