content/browser/indexed_db/indexed_db_class_factory.h - Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_class_factory.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Post dmurph review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/indexed_db/indexed_db_class_factory.h

diff --git a/content/browser/indexed_db/indexed_db_class_factory.h b/content/browser/indexed_db/indexed_db_class_factory.h

index 2f85210326215e084ad7eac2edf5f33bf8b92ef6..420e97dc32717262cfad2fc9b617d2f81785c381 100644

--- a/content/browser/indexed_db/indexed_db_class_factory.h

+++ b/content/browser/indexed_db/indexed_db_class_factory.h

@@ -12,6 +12,7 @@

#include "base/lazy_instance.h"

#include "content/browser/indexed_db/indexed_db_backing_store.h"

cmumford 2016/06/28 20:26:22 No need to include indexed_db_connection.h. Just f

palakj1 2016/06/29 23:02:40 Done.

+#include "content/browser/indexed_db/indexed_db_connection.h"

#include "content/browser/indexed_db/indexed_db_database.h"

#include "content/common/content_export.h"

#include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBTypes.h"

@@ -48,6 +49,7 @@ class CONTENT_EXPORT IndexedDBClassFactory {

virtual IndexedDBTransaction* CreateIndexedDBTransaction(

int64_t id,

+ base::WeakPtr<IndexedDBConnection> connection,

scoped_refptr<IndexedDBDatabaseCallbacks> callbacks,

const std::set<int64_t>& scope,

blink::WebIDBTransactionMode mode,