third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h - Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Post dmurph review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/indexed_db/indexed_db_dispatcher.cc ('K') | « third_party/WebKit/public/blink_headers.gypi ('k') | third_party/WebKit/public/platform/modules/indexeddb/WebIDBObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

diff --git a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

index 4752309714966285f5562d8b948b18b27db9cc06..82807f88e057dea98e62e479d8ff2ad981700780 100644

--- a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

+++ b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

@@ -30,6 +30,7 @@

#include "public/platform/WebCommon.h"

#include "public/platform/modules/indexeddb/WebIDBCursor.h"

#include "public/platform/modules/indexeddb/WebIDBMetadata.h"

+#include "public/platform/modules/indexeddb/WebIDBObserver.h"

#include "public/platform/modules/indexeddb/WebIDBTypes.h"

namespace blink {

@@ -40,6 +41,7 @@ class WebIDBDatabaseCallbacks;

class WebIDBKey;

class WebIDBKeyPath;

class WebIDBKeyRange;

+class WebIDBObserver;

class WebIDBDatabase {

public:

@@ -61,6 +63,8 @@ public:

typedef WebVector<WebIDBKey> WebIndexKeys;

+ virtual void observe(std::unique_ptr<WebIDBObserver>, long long transactionId) = 0;

Marijn Kruisselbrink 2016/06/24 00:48:09 I think it's this API that doesn't make sense to m

+ virtual void unobserve(std::unique_ptr<WebIDBObserver>) = 0;

virtual void get(long long transactionId, long long objectStoreId, long long indexId, const WebIDBKeyRange&, bool keyOnly, WebIDBCallbacks*) = 0;

virtual void getAll(long long transactionId, long long objectStoreId, long long indexId, const WebIDBKeyRange&, long long maxCount, bool keyOnly, WebIDBCallbacks*) = 0;

virtual void put(long long transactionId, long long objectStoreId, const WebData& value, const WebVector<WebBlobInfo>&, const WebIDBKey&, WebIDBPutMode, WebIDBCallbacks*, const WebVector<long long>& indexIds, const WebVector<WebIndexKeys>&) = 0;