IDBObserver: Lifetime Management: Adding Observer

third_party/WebKit/Source/modules/indexeddb/WebIDBObserver.cpp

Index: third_party/WebKit/Source/modules/indexeddb/WebIDBObserver.cpp
diff --git a/third_party/WebKit/Source/web/WebScriptController.cpp b/third_party/WebKit/Source/modules/indexeddb/WebIDBObserver.cpp
similarity index 86%
copy from third_party/WebKit/Source/web/WebScriptController.cpp
copy to third_party/WebKit/Source/modules/indexeddb/WebIDBObserver.cpp
index 624d7f3d5f5217c7c5b55acd5da09161eca4202e..d583a6ba566036e52bd578b8ddc3b6bf11fd8e4d 100644
--- a/third_party/WebKit/Source/web/WebScriptController.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/WebIDBObserver.cpp
@@ -28,15 +28,20 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */

[dmurph, 2016/06/23 21:53:05]

Please use the new copyright header
https://www.chromium.org/developers/coding-style#TOC-File-headers

[palakj1, 2016/06/24 00:03:01]

Done.

 
-#include "public/web/WebScriptController.h"
+#include "public/platform/modules/indexeddb/WebIDBObserver.h"
 
-#include "bindings/core/v8/ScriptController.h"
+#include "modules/indexeddb/IDBObserver.h"
 
 namespace blink {
 
-void WebScriptController::registerExtension(v8::Extension* extension)
+WebIDBObserver::WebIDBObserver(IDBObserver* observer)
+    : m_observer(observer)
 {
-    ScriptController::registerExtensionIfNeeded(extension);
+}
+
+WebIDBObserver::~WebIDBObserver()
+{
+    m_observer.reset();

[dmurph, 2016/06/23 21:53:05]

This happens automatically, you can remove this.

[palakj1, 2016/06/24 00:03:01]

Without explicitly stating that, WebPrivatePtr fails to destruct. (Check failed:
!m_storage)

 }
 
 } // namespace blink