Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: post dmuprh review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
index 16f38a2743d4e68fa79548aefa0dd05e17e557bb..43e196ed7132b58433a556b75f7c7d07fe3b68cb 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
@@ -6,14 +6,15 @@
#define IDBObserver_h
dmurph 2016/06/23 21:53:05 Please use the new copyright header https://www.ch
palakj1 2016/06/24 00:03:01 Isn't it the same header?
#include "bindings/core/v8/ScriptWrappable.h"
-#include "modules/indexeddb/IDBDatabase.h"
-#include "modules/indexeddb/IDBTransaction.h"
#include "platform/heap/Handle.h"
namespace blink {
+class ExceptionState;
class IDBObserverCallback;
class IDBObserverInit;
+class IDBDatabase;
+class IDBTransaction;
class IDBObserver final : public GarbageCollectedFinalized<IDBObserver>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
@@ -23,11 +24,12 @@ public:
~IDBObserver();
// API methods
void observe(IDBDatabase*, IDBTransaction*, ExceptionState&);
+ void unobserve(IDBDatabase*, ExceptionState&);
DECLARE_TRACE();
private:
- explicit IDBObserver(IDBObserverCallback&, const IDBObserverInit&);
+ IDBObserver(IDBObserverCallback&, const IDBObserverInit&);
Member<IDBObserverCallback> m_callback;
bool m_transaction;

Powered by Google App Engine
This is Rietveld 408576698