Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Observer moved to connection Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditCategory.js b/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h
similarity index 66%
copy from third_party/WebKit/Source/devtools/front_end/audits/AuditCategory.js
copy to third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h
index 6b024e7b3bb3d6475ecfb850330fec856ef2013c..b174f0fe6e09f31c1f2e18aeedfc0b36eb458680 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditCategory.js
+++ b/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2014 Google Inc. All rights reserved.
+ * Copyright (C) 2013 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -26,35 +26,32 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-/**
- * @interface
- */
-WebInspector.AuditCategory = function()
-{
-}
-
-WebInspector.AuditCategory.prototype = {
- /**
- * @return {string}
- */
- get id()
- {
- },
-
- /**
- * @return {string}
- */
- get displayName()
- {
- },
-
- /**
- * @param {!WebInspector.Target} target
- * @param {!Array.<!WebInspector.NetworkRequest>} requests
- * @param {function(!WebInspector.AuditRuleResult)} ruleResultCallback
- * @param {!WebInspector.Progress} progress
- */
- run: function(target, requests, ruleResultCallback, progress)
- {
- }
-}
+#ifndef WebIDBObserverImpl_h
+#define WebIDBObserverImpl_h
+
+#include "public/platform/WebString.h"
+#include "public/platform/modules/indexeddb/WebIDBObserver.h"
+#include "wtf/PassOwnPtr.h"
dmurph 2016/06/22 01:09:50 Please double check these headers.
+
+namespace blink {
+
+class IDBObserver;
+class WebIDBDatabase;
+
+class WebIDBObserverImpl final : public WebIDBObserver {
dmurph 2016/06/22 01:09:50 Can your IDBObserver just extend WeBIDBOBserver in
palakj1 2016/06/23 20:56:30 Done.
+ USING_FAST_MALLOC(WebIDBObserverImpl);
+
+public:
+ static PassOwnPtr<WebIDBObserverImpl> create(IDBObserver*);
+
+ ~WebIDBObserverImpl() override;
+
+private:
+ explicit WebIDBObserverImpl(IDBObserver*);
+
+ Persistent<IDBObserver> m_observer;
+};
+
+} // namespace blink
+
+#endif // WebIDBObserverImpl_h

Powered by Google App Engine
This is Rietveld 408576698