IDBObserver: Lifetime Management: Adding Observer

third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "modules/indexeddb/WebIDBObserverImpl.h"
+
+#include "modules/indexeddb/IDBObserver.h"
+#include "wtf/PtrUtil.h"
+
+namespace blink {
+
+// static
+std::unique_ptr<WebIDBObserverImpl> WebIDBObserverImpl::create(IDBObserver* observer)
+{
+    return wrapUnique(new WebIDBObserverImpl(observer));
+}
+
+WebIDBObserverImpl::WebIDBObserverImpl(IDBObserver* observer)
+    : m_observer(observer)

[cmumford, 2016/07/06 22:57:57]

m_id is not initialized in the constructor.

[palakj1, 2016/07/07 00:19:54]

Done.

+{
+}
+
+// Remove observe call id from IDBObserver.
+WebIDBObserverImpl::~WebIDBObserverImpl()
+{
+    m_observer->removeObserver(m_id);

[cmumford, 2016/07/06 22:57:57]

You should create some constant to represent the uninitialized value for m_id,
and only call removeObserver if it has been set via setId().

[palakj1, 2016/07/07 00:19:54]

Done.

+}
+
+} // namespace blink