Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Units tests added Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/indexeddb/IDBObserver.h" 5 #include "modules/indexeddb/IDBObserver.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/modules/v8/ToV8ForModules.h" 8 #include "bindings/modules/v8/ToV8ForModules.h"
9 #include "bindings/modules/v8/V8BindingForModules.h" 9 #include "bindings/modules/v8/V8BindingForModules.h"
10 #include "core/dom/ExceptionCode.h"
11 #include "modules/indexeddb/IDBDatabase.h"
10 #include "modules/indexeddb/IDBObserverCallback.h" 12 #include "modules/indexeddb/IDBObserverCallback.h"
11 #include "modules/indexeddb/IDBObserverInit.h" 13 #include "modules/indexeddb/IDBObserverInit.h"
14 #include "modules/indexeddb/IDBTransaction.h"
15 #include "modules/indexeddb/WebIDBObserverImpl.h"
12 16
13 namespace blink { 17 namespace blink {
14 18
15 IDBObserver* IDBObserver::create(IDBObserverCallback& callback, const IDBObserve rInit& options) 19 IDBObserver* IDBObserver::create(IDBObserverCallback& callback, const IDBObserve rInit& options)
16 { 20 {
17 return new IDBObserver(callback, options); 21 return new IDBObserver(callback, options);
18 } 22 }
19 23
20 IDBObserver::IDBObserver(IDBObserverCallback& callback, const IDBObserverInit& o ptions) 24 IDBObserver::IDBObserver(IDBObserverCallback& callback, const IDBObserverInit& o ptions)
21 : m_callback(&callback) 25 : m_callback(&callback)
22 , m_transaction(options.transaction()) 26 , m_transaction(options.transaction())
23 , m_values(options.values()) 27 , m_values(options.values())
24 , m_noRecords(options.noRecords()) 28 , m_noRecords(options.noRecords())
25 { 29 {
26 } 30 }
27 31
32 IDBObserver::~IDBObserver() {}
33
28 void IDBObserver::observe(IDBDatabase* database, IDBTransaction* transaction, Ex ceptionState& exceptionState) 34 void IDBObserver::observe(IDBDatabase* database, IDBTransaction* transaction, Ex ceptionState& exceptionState)
29 { 35 {
30 // TODO(palakj): Finish implementation. 36 if (transaction->isFinished() || transaction->isFinishing()) {
37 exceptionState.throwDOMException(TransactionInactiveError, IDBDatabase:: transactionFinishedErrorMessage);
38 return;
39 }
40 if (!transaction->isActive()) {
41 exceptionState.throwDOMException(TransactionInactiveError, IDBDatabase:: transactionInactiveErrorMessage);
42 return;
43 }
44 if (!database->backend()) {
45 exceptionState.throwDOMException(InvalidStateError, IDBDatabase::databas eClosedErrorMessage);
46 return;
47 }
48
49 int32_t observerId = database->backend()->addObserver(WebIDBObserverImpl::cr eate(this), transaction->id());
50 m_observerIds.insert(observerId);
51 }
52
53 void IDBObserver::unobserve(IDBDatabase* database, ExceptionState& exceptionStat e)
54 {
55 if (!database->backend()) {
56 exceptionState.throwDOMException(InvalidStateError, IDBDatabase::databas eClosedErrorMessage);
57 return;
58 }
59 std::set<int32_t>::iterator it = m_observerIds.begin();
60 std::vector<int32_t> observerIdsToRemove;
61 while (it != m_observerIds.end()) {
62 if (database->backend()->containsObserverId(*it)) {
63 observerIdsToRemove.push_back(*it);
64 it = m_observerIds.erase(it);
65 } else {
66 it++;
67 }
68 }
69 if (!observerIdsToRemove.empty())
70 database->backend()->removeObservers(observerIdsToRemove);
71 }
72
73 void IDBObserver::removeObserver(int32_t id)
74 {
75 m_observerIds.erase(id);
31 } 76 }
32 77
33 DEFINE_TRACE(IDBObserver) 78 DEFINE_TRACE(IDBObserver)
34 { 79 {
35 visitor->trace(m_callback); 80 visitor->trace(m_callback);
36 } 81 }
37 82
38 } // namespace blink 83 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698