IDBObserver: Lifetime Management: Adding Observer

content/child/indexed_db/webidbdatabase_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_INDEXED_DB_WEBIDBDATABASE_IMPL_H_
 #define CONTENT_CHILD_INDEXED_DB_WEBIDBDATABASE_IMPL_H_
 
 #include <stdint.h>
 
 #include "base/memory/ref_counted.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBTypes.h"
 
 namespace blink {
 class WebBlobInfo;
 class WebIDBCallbacks;
 class WebIDBDatabaseCallbacks;
+class WebIDBObserver;
 class WebString;
 }
 
 namespace content {
 class ThreadSafeSender;
 
 class WebIDBDatabaseImpl : public blink::WebIDBDatabase {
  public:
   WebIDBDatabaseImpl(int32_t ipc_database_id,
                      int32_t ipc_database_callbacks_id,
                      ThreadSafeSender* thread_safe_sender);
   ~WebIDBDatabaseImpl() override;
 
   // blink::WebIDBDatabase
   void createObjectStore(long long transaction_id,
                          long long objectstore_id,
                          const blink::WebString& name,
                          const blink::WebIDBKeyPath& key_path,
                          bool auto_increment) override;
   void deleteObjectStore(long long transaction_id,
                          long long object_store_id) override;
   void createTransaction(long long transaction_id,
                          blink::WebIDBDatabaseCallbacks* callbacks,
                          const blink::WebVector<long long>& scope,
                          blink::WebIDBTransactionMode mode) override;
 
   void close() override;
   void versionChangeIgnored() override;
 
+  int32_t addObserver(blink::WebIDBObserver*, long long transactionId) override;
+  // returns true if the element has been removed from the set.

[dmurph, 2016/06/27 21:20:51]

Please capitalize the sentence (all comments should be complete sentences).

[palakj1, 2016/06/27 23:13:08]

Done.

+  bool removeObserverId(int32_t id) override;
+  void removeObservers(
+      const std::vector<int32_t>& observer_ids_to_remove) override;
+
   void get(long long transactionId,
            long long objectStoreId,
            long long indexId,
            const blink::WebIDBKeyRange&,
            bool keyOnly,
            blink::WebIDBCallbacks*) override;
   void getAll(long long transactionId,
               long long objectStoreId,
               long long indexId,
               const blink::WebIDBKeyRange&,
@@ skipping 48 matching lines @@
                    long long objectStoreId,
                    long long indexId) override;
   void abort(long long transaction_id) override;
   void commit(long long transaction_id) override;
   void ackReceivedBlobs(
       const blink::WebVector<blink::WebString>& uuids) override;
 
  private:
   int32_t ipc_database_id_;
   int32_t ipc_database_callbacks_id_;
+  std::set<int32_t> observer_ids_;
   scoped_refptr<ThreadSafeSender> thread_safe_sender_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_INDEXED_DB_WEBIDBDATABASE_IMPL_H_