Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/parsing/parser.cc

Issue 2062203002: Parser: Report use counts once per feature (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Improve commit message Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/parsing/parser.h" 5 #include "src/parsing/parser.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/ast/ast.h" 8 #include "src/ast/ast.h"
9 #include "src/ast/ast-expression-rewriter.h" 9 #include "src/ast/ast-expression-rewriter.h"
10 #include "src/ast/ast-expression-visitor.h" 10 #include "src/ast/ast-expression-visitor.h"
(...skipping 5196 matching lines...) Expand 10 before | Expand all | Expand 10 after
5207 isolate->StackOverflow(); 5207 isolate->StackOverflow();
5208 } else { 5208 } else {
5209 DCHECK(pending_error_handler_.has_pending_error()); 5209 DCHECK(pending_error_handler_.has_pending_error());
5210 pending_error_handler_.ThrowPendingError(isolate, script); 5210 pending_error_handler_.ThrowPendingError(isolate, script);
5211 } 5211 }
5212 } 5212 }
5213 5213
5214 // Move statistics to Isolate. 5214 // Move statistics to Isolate.
5215 for (int feature = 0; feature < v8::Isolate::kUseCounterFeatureCount; 5215 for (int feature = 0; feature < v8::Isolate::kUseCounterFeatureCount;
5216 ++feature) { 5216 ++feature) {
5217 for (int i = 0; i < use_counts_[feature]; ++i) { 5217 if (use_counts_[feature] > 0) {
5218 isolate->CountUsage(v8::Isolate::UseCounterFeature(feature)); 5218 isolate->CountUsage(v8::Isolate::UseCounterFeature(feature));
5219 } 5219 }
5220 } 5220 }
5221 if (scanner_.FoundHtmlComment()) { 5221 if (scanner_.FoundHtmlComment()) {
5222 isolate->CountUsage(v8::Isolate::kHtmlComment); 5222 isolate->CountUsage(v8::Isolate::kHtmlComment);
5223 if (script->line_offset() == 0 && script->column_offset() == 0) { 5223 if (script->line_offset() == 0 && script->column_offset() == 0) {
5224 isolate->CountUsage(v8::Isolate::kHtmlCommentInExternalScript); 5224 isolate->CountUsage(v8::Isolate::kHtmlCommentInExternalScript);
5225 } 5225 }
5226 } 5226 }
5227 isolate->counters()->total_preparse_skipped()->Increment( 5227 isolate->counters()->total_preparse_skipped()->Increment(
(...skipping 1751 matching lines...) Expand 10 before | Expand all | Expand 10 after
6979 try_block, target); 6979 try_block, target);
6980 final_loop = target; 6980 final_loop = target;
6981 } 6981 }
6982 6982
6983 return final_loop; 6983 return final_loop;
6984 } 6984 }
6985 6985
6986 6986
6987 } // namespace internal 6987 } // namespace internal
6988 } // namespace v8 6988 } // namespace v8
OLDNEW
« no previous file with comments | « AUTHORS ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698