Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chrome/browser/resources/settings/printing_page/printing_page.js

Issue 2062163004: MD Settings: make devices open in a new tab rather than clobber current one (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 Polymer({ 5 Polymer({
6 is: 'settings-printing-page', 6 is: 'settings-printing-page',
7 7
8 properties: { 8 properties: {
9 prefs: { 9 prefs: {
10 type: Object, 10 type: Object,
11 notify: true, 11 notify: true,
12 }, 12 },
13 }, 13 },
14 14
15 /** @private */ 15 /** @private */
16 onManageTap_: function() { 16 onManageTap_: function() {
17 location.href = loadTimeData.getString('devicesUrl'); 17 window.open(loadTimeData.getString('devicesUrl'));
groby-ooo-7-16 2016/06/14 23:47:00 nit: We'll move these strings to $i18n{} at some p
Dan Beam 2016/06/14 23:59:14 we only search/replace $i18n{} in html files right
18 }, 18 },
19 }); 19 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698