third_party: Update to version 6 of remote_shell_protocol

third_party: Update to version 6 of remote_shell_protocol

Adds notification_surface to remote_shell_protocol.

BUG=b/25816173

Committed: https://crrev.com/ac9f9a5461cce3b952af868bb46a14a73d58e814
Cr-Commit-Position: refs/heads/master@{#401680}

[xiyuan, 2016-06-14 16:46:58]

xiyuan@chromium.org changed reviewers:
+ reveman@chromium.org, yoshiki@chromium.org

[xiyuan, 2016-06-14 16:46:59]

reveman@, please review.

yoshiki@, optionally for you. fyi so that you can review the incoming CLs based
on this.

[reveman, 2016-06-14 17:05:35]

lgtm with nits but please wait to land this until components/exo changes are
also ready to land

https://codereview.chromium.org/2062133002/diff/1/third_party/wayland-protoco...
File third_party/wayland-protocols/protocol/remote-shell-protocol.c (left):

https://codereview.chromium.org/2062133002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/protocol/remote-shell-protocol.c:1: /* Generated
by wayland-scanner 1.11.0 */
nit: please use wayland-scanner 1.11.0 to generate these sources. you can find
wayland-scanner 1.11.0 in third_party/wayland/src/.

https://codereview.chromium.org/2062133002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2062133002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:381:
<interface name="zwp_notification_surface_v1" version="4">
nit: please add "<!-- Version 4 additions -->" and a blank line above this

[xiyuan, 2016-06-14 17:27:09]

https://codereview.chromium.org/2062133002/diff/1/third_party/wayland-protoco...
File third_party/wayland-protocols/protocol/remote-shell-protocol.c (left):

https://codereview.chromium.org/2062133002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/protocol/remote-shell-protocol.c:1: /* Generated
by wayland-scanner 1.11.0 */
On 2016/06/14 17:05:35, reveman wrote:
> nit: please use wayland-scanner 1.11.0 to generate these sources. you can find
> wayland-scanner 1.11.0 in third_party/wayland/src/.

Done.

https://codereview.chromium.org/2062133002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2062133002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:381:
<interface name="zwp_notification_surface_v1" version="4">
On 2016/06/14 17:05:35, reveman wrote:
> nit: please add "<!-- Version 4 additions -->" and a blank line above this

Done.

[yoshiki, 2016-06-15 14:31:45]

lgtm

[xiyuan, 2016-06-23 18:21:11]

Description was changed from

==========
third_party: Update to version 4 of remote_shell_protocol

Adds notification_surface to remote_shell_protocol.

BUG=b/25816173
==========

to

==========
third_party: Update to version 6 of remote_shell_protocol

Adds notification_surface to remote_shell_protocol.

BUG=b/25816173
==========

[xiyuan, 2016-06-23 18:25:08]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2016-06-23 18:25:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/2062133002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-23 18:25:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062133002/60001

[reveman, 2016-06-23 18:28:00]

https://codereview.chromium.org/2062133002/diff/60001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2062133002/diff/60001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:89:
<request name="get_notification_surface" since="6">
please move this down to "Version 6 additions" section

[xiyuan, 2016-06-23 18:28:36]

The CQ bit was unchecked by xiyuan@chromium.org

[xiyuan, 2016-06-23 18:34:11]

https://codereview.chromium.org/2062133002/diff/60001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2062133002/diff/60001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:89:
<request name="get_notification_surface" since="6">
On 2016/06/23 18:28:00, reveman wrote:
> please move this down to "Version 6 additions" section

Added a "Version 6 additions" section for zwp_remote_shell_v1 interface and move
it there.

[xiyuan, 2016-06-23 19:21:04]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2016-06-23 19:21:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
yoshiki@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2062133002/#ps80001
(title: "move get_notification_surface down")

[commit-bot: I haz the power, 2016-06-23 19:22:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062133002/80001

[commit-bot: I haz the power, 2016-06-23 19:28:22]

Description was changed from

==========
third_party: Update to version 6 of remote_shell_protocol

Adds notification_surface to remote_shell_protocol.

BUG=b/25816173
==========

to

==========
third_party: Update to version 6 of remote_shell_protocol

Adds notification_surface to remote_shell_protocol.

BUG=b/25816173
==========

[commit-bot: I haz the power, 2016-06-23 19:28:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-23 19:31:37]

Description was changed from

==========
third_party: Update to version 6 of remote_shell_protocol

Adds notification_surface to remote_shell_protocol.

BUG=b/25816173
==========

to

==========
third_party: Update to version 6 of remote_shell_protocol

Adds notification_surface to remote_shell_protocol.

BUG=b/25816173

Committed: https://crrev.com/ac9f9a5461cce3b952af868bb46a14a73d58e814
Cr-Commit-Position: refs/heads/master@{#401680}
==========

[commit-bot: I haz the power, 2016-06-23 19:31:39]

Patchset 5 (id:??) landed as
https://crrev.com/ac9f9a5461cce3b952af868bb46a14a73d58e814
Cr-Commit-Position: refs/heads/master@{#401680}