Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: runtime/vm/service_test.cc

Issue 206213004: Add a VM page to the observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: before review Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service_test.cc
diff --git a/runtime/vm/service_test.cc b/runtime/vm/service_test.cc
index 88d5ef87ac135524ab3f3864450c2c8f0d66d0c3..5e8218b3081c7ad52aa94296a7611f1c5b9e3e91 100644
--- a/runtime/vm/service_test.cc
+++ b/runtime/vm/service_test.cc
@@ -874,7 +874,7 @@ TEST_CASE(Service_Code) {
}
-TEST_CASE(Service_Cpu) {
+TEST_CASE(Service_VM) {
const char* kScript =
"var port;\n" // Set to our mock port by C++.
"\n"
@@ -894,11 +894,15 @@ TEST_CASE(Service_Cpu) {
EXPECT_VALID(Dart_SetField(lib, NewString("port"), port));
Instance& service_msg = Instance::Handle();
- service_msg = Eval(lib, "[port, ['cpu'], [], []]");
+ service_msg = Eval(lib, "[port, ['vm'], [], []]");
Service::HandleRootMessage(service_msg);
handler.HandleNextMessage();
- EXPECT_SUBSTRING("\"type\":\"CPU\"", handler.msg());
+ EXPECT_SUBSTRING("\"type\":\"VM\",\"id\":\"vm\"", handler.msg());
+ EXPECT_SUBSTRING("\"architecture\"", handler.msg());
+ EXPECT_SUBSTRING("\"version\"", handler.msg());
+ EXPECT_SUBSTRING("\"uptime\"", handler.msg());
+ EXPECT_SUBSTRING("\"isolates\"", handler.msg());
}

Powered by Google App Engine
This is Rietveld 408576698