Implements the Lightweight First Run Experience

chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.document;
 
 import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.app.Notification;
 import android.app.PendingIntent;
@@ skipping 469 matching lines @@
 
     /**
      * Tries to launch the First Run Experience.  If ChromeLauncherActivity is running with the
      * wrong Intent flags, we instead relaunch ChromeLauncherActivity to make sure it runs in its
      * own task, which then triggers First Run.
      * @return Whether or not the First Run Experience needed to be shown.
      */
     private boolean launchFirstRunExperience() {
         final boolean isIntentActionMain = getIntent() != null
                 && TextUtils.equals(getIntent().getAction(), Intent.ACTION_MAIN);
-        final Intent freIntent = FirstRunFlowSequencer.checkIfFirstRunIsNecessary(
-                this, isIntentActionMain);
+        final Intent freIntent =
+                FirstRunFlowSequencer.checkIfFirstRunIsNecessary(this, isIntentActionMain,
+                        IntentHandler.determineExternalIntentSource(getPackageName(), getIntent()));

[Bernhard Bauer, 2016/06/16 16:35:36]

You pass this to checkIfFirstRunIsNecessary() every single time. Could that
method just determine the external intent source?

[gogerald1, 2016/06/16 18:59:20]

Done.

         if (freIntent == null) return false;
 
         if ((getIntent().getFlags() & Intent.FLAG_ACTIVITY_NEW_TASK) != 0) {
             startActivityForResult(freIntent, FIRST_RUN_EXPERIENCE_REQUEST_CODE);
         } else {
             Intent newIntent = new Intent(getIntent());
             newIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
             startActivity(newIntent);
             finish();
         }
         return true;
     }
 
     /**
      * Records metrics gleaned from the Intent.
      */
     private void recordIntentMetrics() {
         Intent intent = getIntent();
         IntentHandler.ExternalAppId source =
                 IntentHandler.determineExternalIntentSource(getPackageName(), intent);
         if (intent.getPackage() == null && source != IntentHandler.ExternalAppId.CHROME) {
             int flagsOfInterest = Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_NEW_DOCUMENT;
             int maskedFlags = intent.getFlags() & flagsOfInterest;
             sIntentFlagsHistogram.record(maskedFlags);
         }
         MediaNotificationUma.recordClickSource(intent);
     }
 }