Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2062053002:
cit: print to stderr to allow piping from cit log cat. (Closed)
|
Created:
4 years, 6 months ago by tandrii(chromium) Modified:
4 years, 6 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
Descriptioncit: print to stderr to allow piping from cit log cat.
R=hinoka@chromium.org,stip@chromium.org
BUG=
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/56396af3e5f4887c9efd7164a590834ef2511d8f
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (7 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062053002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
hinoka@google.com changed reviewers: + hinoka@google.com
lgtm https://codereview.chromium.org/2062053002/diff/1/cit.py File cit.py (right): https://codereview.chromium.org/2062053002/diff/1/cit.py#newcode59 cit.py:59: sys.stderr.write( use print >>sys.stderr, "..." Either that, or add a newline. I like using print >> pipe better.
https://codereview.chromium.org/2062053002/diff/1/cit.py File cit.py (right): https://codereview.chromium.org/2062053002/diff/1/cit.py#newcode59 cit.py:59: sys.stderr.write( On 2016/06/14 17:41:08, Ryan Tseng wrote: > use print >>sys.stderr, "..." > > Either that, or add a newline. I like using print >> pipe better. Actually, the whole reason for using stderr.write is so that I avoid new line. I wanted to see one line like this: checking out infra..... done.
Ohhhh got it. lgtm as is then
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062053002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062053002/1
Message was sent while issue was closed.
Description was changed from ========== cit: print to stderr to allow piping from cit log cat. R=hinoka@chromium.org,stip@chromium.org BUG= ========== to ========== cit: print to stderr to allow piping from cit log cat. R=hinoka@chromium.org,stip@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/56396af3e5f488... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/56396af3e5f488... |
