Fetch incremental updates. Store new state in V4Store.

chrome/browser/safe_browsing/services_delegate_impl.cc

Index: chrome/browser/safe_browsing/services_delegate_impl.cc
diff --git a/chrome/browser/safe_browsing/services_delegate_impl.cc b/chrome/browser/safe_browsing/services_delegate_impl.cc
index 5eba56f7716539bb0d9f7b032affc34352cf31fe..8a513a410e98fc748e33ac1e064a4ea258dbc7e5 100644
--- a/chrome/browser/safe_browsing/services_delegate_impl.cc
+++ b/chrome/browser/safe_browsing/services_delegate_impl.cc
@@ -17,12 +17,14 @@
 
 namespace safe_browsing {
 
+#ifdef NDEBUG

[Scott Hess - ex-Googler, 2016/06/21 22:23:25]

Grrr, stupid compiler.

WDYT of structuring the later thing as:

#ifndef NDEBUG
  return true;
#endif
  return base::FeatureList::IsEnabled(
    kSafeBrowsingV4LocalDatabaseManagerEnabled);

???

[vakh (use Gerrit instead), 2016/06/23 06:23:49]

D'oh! Should have done that in the first place. Done now.

 namespace {
 const base::Feature kSafeBrowsingV4LocalDatabaseManagerEnabled {
     "SafeBrowsingV4LocalDatabaseManagerEnabled",
     base::FEATURE_DISABLED_BY_DEFAULT
 };
 }  // namespace
+#endif
 
 // static
 std::unique_ptr<ServicesDelegate> ServicesDelegate::Create(
@@ -184,8 +186,13 @@ V4LocalDatabaseManager* ServicesDelegateImpl::CreateV4LocalDatabaseManager() {
 }
 
 bool ServicesDelegateImpl::IsV4LocalDatabaseManagerEnabled() {
-  return base::FeatureList::IsEnabled(
-      kSafeBrowsingV4LocalDatabaseManagerEnabled);
+#ifndef NDEBUG
+  return true;
+#else
+  bool enabled =
+      base::FeatureList::IsEnabled(kSafeBrowsingV4LocalDatabaseManagerEnabled);
+  return enabled;
+#endif
 }
 
 }  // namespace safe_browsing