chrome/browser/safe_browsing/services_delegate_impl.cc - Issue 2062013002: Fetch incremental updates. Store new state in V4Store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/services_delegate_impl.cc

Issue 2062013002: Fetch incremental updates. Store new state in V4Store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits: Added some comments in BUILD.gn. Using #else for platform_type until I resolve the android bu… Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/services_delegate_impl.cc

diff --git a/chrome/browser/safe_browsing/services_delegate_impl.cc b/chrome/browser/safe_browsing/services_delegate_impl.cc

index 5eba56f7716539bb0d9f7b032affc34352cf31fe..5d1c7d23ed3c13f4323a299f122a9aa35b4752c3 100644

--- a/chrome/browser/safe_browsing/services_delegate_impl.cc

+++ b/chrome/browser/safe_browsing/services_delegate_impl.cc

@@ -184,8 +184,12 @@ V4LocalDatabaseManager* ServicesDelegateImpl::CreateV4LocalDatabaseManager() {

}

bool ServicesDelegateImpl::IsV4LocalDatabaseManagerEnabled() {

- return base::FeatureList::IsEnabled(

- kSafeBrowsingV4LocalDatabaseManagerEnabled);

+ bool enabled =

+ base::FeatureList::IsEnabled(kSafeBrowsingV4LocalDatabaseManagerEnabled);

+#ifndef NDEBUG

+ enabled = true;

+#endif

Scott Hess - ex-Googler 2016/06/17 22:53:42 I'd be comfortable with just having the #if case r

vakh (use Gerrit instead) 2016/06/20 22:28:42 Done.

+ return enabled;

}

} // namespace safe_browsing

« no previous file with comments | « no previous file | components/safe_browsing_db/BUILD.gn » ('j') | components/safe_browsing_db/v4_database.h » ('J')