Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2062003002: [wasm] Relocatable Globals (Closed)

Created:
4 years, 6 months ago by Mircea Trofin
Modified:
4 years, 6 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Relocatable Globals. Support for relocatable globals, to facilitate compilation before instantiation. BUG=v8:5072 Committed: https://crrev.com/2d1f977c93942f58f0aaf886adb346f4eba5a1ea Cr-Commit-Position: refs/heads/master@{#36978}

Patch Set 1 #

Patch Set 2 : {float|double}_t -> {float|double} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -12 lines) Patch
M src/arm/assembler-arm.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/assembler.h View 3 chunks +8 lines, -0 lines 0 comments Download
M src/assembler.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 2 chunks +5 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/wasm/test-run-wasm-relocation.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Mircea Trofin
4 years, 6 months ago (2016-06-14 02:21:07 UTC) #3
bradnelson
lgtm
4 years, 6 months ago (2016-06-14 04:16:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062003002/1
4 years, 6 months ago (2016-06-14 04:16:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062003002/20001
4 years, 6 months ago (2016-06-14 04:20:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17134)
4 years, 6 months ago (2016-06-14 05:24:34 UTC) #12
Mircea Trofin
+titzer for OWNERS
4 years, 6 months ago (2016-06-14 05:27:32 UTC) #14
titzer
lgtm
4 years, 6 months ago (2016-06-14 20:56:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062003002/20001
4 years, 6 months ago (2016-06-14 21:11:56 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 21:38:33 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 21:41:45 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d1f977c93942f58f0aaf886adb346f4eba5a1ea
Cr-Commit-Position: refs/heads/master@{#36978}

Powered by Google App Engine
This is Rietveld 408576698