Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: gpu/ipc/service/image_transport_surface_overlay_mac.mm

Issue 2061993003: Pass responsibility for IOSurface-texture reuse to the gpu process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp85_query_in_use
Patch Set: Compile errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/ipc/service/image_transport_surface_overlay_mac.mm
diff --git a/gpu/ipc/service/image_transport_surface_overlay_mac.mm b/gpu/ipc/service/image_transport_surface_overlay_mac.mm
index fef796a7c0f7c91138b60db3998cb34669a3356b..bf03dc6fbeb08db14c3d73141d53a04c7f8258c1 100644
--- a/gpu/ipc/service/image_transport_surface_overlay_mac.mm
+++ b/gpu/ipc/service/image_transport_surface_overlay_mac.mm
@@ -159,15 +159,13 @@ void ImageTransportSurfaceOverlayMac::SendAcceleratedSurfaceBuffersSwapped(
params.latency_info = std::move(latency_info);
params.result = gfx::SwapResult::SWAP_ACK;
- // TODO(erikchen): Re-enable this logic alongside the client code that
- // consumes this response. https://crbug.com/608026.
- // for (auto& query : io_surface_in_use_queries_) {
- // SwapBuffersCompletedIOSurfaceInUseQuery response;
- // response.texture = query.texture;
- // response.in_use =
- // query.io_surface.get() && IOSurfaceIsInUse(query.io_surface.get());
- // params.in_use_queries.push_back(std::move(response));
- // }
+ for (auto& query : io_surface_in_use_queries_) {
+ gpu::TextureInUseResponse response;
+ response.texture = query.texture;
+ response.in_use =
+ query.io_surface.get() && IOSurfaceIsInUse(query.io_surface.get());
+ params.in_use_responses.push_back(std::move(response));
+ }
io_surface_in_use_queries_.clear();
stub_->SendSwapBuffersCompleted(params);

Powered by Google App Engine
This is Rietveld 408576698