Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2061973002: Get rid of IPDF_DataAvail. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cast #

Patch Set 3 : fix build #

Patch Set 4 : unique_ptr #

Total comments: 2

Patch Set 5 : rebase, nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -498 lines) Patch
M BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
D core/fpdfapi/fpdf_parser/cpdf_data_avail.h View 1 chunk +0 lines, -217 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 1 2 3 4 41 chunks +55 lines, -77 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.h View 2 chunks +3 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
A + core/fpdfapi/fpdf_parser/include/cpdf_data_avail.h View 5 chunks +95 lines, -60 lines 0 comments Download
D core/fpdfapi/fpdf_parser/include/ipdf_data_avail.h View 1 chunk +0 lines, -80 lines 0 comments Download
M fpdfsdk/fpdf_dataavail.cpp View 1 2 3 6 chunks +47 lines, -38 lines 0 comments Download
M pdfium.gyp View 9 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
4 years, 6 months ago (2016-06-13 23:57:29 UTC) #2
dsinclair
lgtm w/ nit https://codereview.chromium.org/2061973002/diff/60001/core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right): https://codereview.chromium.org/2061973002/diff/60001/core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp#newcode1247 core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:1247: CPDF_DataAvail::PageNode* pPageNode, Can the CPDF_DataAvail:: be ...
4 years, 6 months ago (2016-06-14 13:16:17 UTC) #3
Wei Li
lgtm
4 years, 6 months ago (2016-06-14 16:35:34 UTC) #4
Lei Zhang
https://codereview.chromium.org/2061973002/diff/60001/core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right): https://codereview.chromium.org/2061973002/diff/60001/core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp#newcode1247 core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:1247: CPDF_DataAvail::PageNode* pPageNode, On 2016/06/14 13:16:17, dsinclair wrote: > Can ...
4 years, 6 months ago (2016-06-14 17:37:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061973002/80001
4 years, 6 months ago (2016-06-14 17:37:46 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://pdfium.googlesource.com/pdfium/+/979070b3ef34aa36ef14e2a09260b057e0265916
4 years, 6 months ago (2016-06-14 17:44:06 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 17:44:08 UTC) #11
Message was sent while issue was closed.
CQ bit was unchecked

Powered by Google App Engine
This is Rietveld 408576698