third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py - Issue 2061963002: Disable NeedsRebaseline and webkit-patch rebaseline[-expectations]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

Issue 2061963002: Disable NeedsRebaseline and webkit-patch rebaseline[-expectations] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable NeedsRebaseline and webkit-patch rebaseline[-expectations] Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

index 73e336cb89d3dc071a846a175802c54c4f57d113..d0a3e2cd4472c5d5c31aa7006aa78796b01183da 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

@@ -194,7 +194,8 @@ class MiscTests(Base):

s = self._exp.get_test_set(CRASH)

self.assertEqual(s, set(['failures/expected/crash.html', 'failures/expected/image_checksum.html']))

- def test_needs_rebaseline_reftest(self):

+ # TODO(crbug.com/574272) - Reenable this after the bug is fixed.

+ def disabled_test_needs_rebaseline_reftest(self):

try:

filesystem = self._port.host.filesystem

filesystem.write_text_file(

@@ -263,7 +264,8 @@ Bug(user) reftests/failures/expected/needsmanualrebaseline_with_txt.html [ Needs

expectations:3 A reftest without text expectation cannot be marked as NeedsRebaseline/NeedsManualRebaseline reftests/failures/expected/needsmanualrebaseline.html"""

self.assertEqual(str(e), warnings)

- def test_parse_warning(self):

+ # TODO(crbug.com/574272) - Reenable this after the bug is fixed.

+ def disabled_test_parse_warning(self):

try:

filesystem = self._port.host.filesystem

filesystem.write_text_file(filesystem.join(self._port.layout_tests_dir(), 'disabled-test.html-disabled'), 'content')