Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2061953002: Do not call CollectContextGraphicsInfo if GL has failed to initialize (Closed)

Created:
4 years, 6 months ago by Julien Isorce Samsung
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not call CollectContextGraphicsInfo if GL has failed to initialize If the gpu process is not yet launch when calling GpuDataManagerImplPrivate::RequestCompleteGpuInfoIfNeeded() it will cause to start the gpu process and send the message GpuMsg_CollectGraphicsInfo right away. (possible causes: browser_bridge.js, SystemInfoHandler::GetInfo, GPUFeatureChecker) On gpu side this will cause to call GpuMain, GpuChildThread's constructor, OnInitialize and OnCollectGraphicsInfo sequentially. If dead_on_arrival_ is true then GpuChildThread::OnInitialize calls base::MessageLoop::current()->QuitWhenIdle() which might let handle the pending GpuMsg_CollectGraphicsInfo message. BUG=619106 R=jbauman@chromium.org, kbr@chromium.org, piman@chromium.org, zmo@chromium.org Committed: https://crrev.com/e02f94b59fa148e354db57a0f5d38f6bb644aa55 Cr-Commit-Position: refs/heads/master@{#399669}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/gpu/gpu_child_thread.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061953002/1
4 years, 6 months ago (2016-06-13 23:28:45 UTC) #2
Ken Russell (switch to Gerrit)
Thanks for proposing this straightforward fix. LGTM
4 years, 6 months ago (2016-06-13 23:33:58 UTC) #3
piman
lgtm
4 years, 6 months ago (2016-06-13 23:54:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/87016)
4 years, 6 months ago (2016-06-14 01:47:22 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061953002/20001
4 years, 6 months ago (2016-06-14 07:45:03 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 08:22:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061953002/20001
4 years, 6 months ago (2016-06-14 08:27:23 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 08:31:14 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 08:32:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e02f94b59fa148e354db57a0f5d38f6bb644aa55
Cr-Commit-Position: refs/heads/master@{#399669}

Powered by Google App Engine
This is Rietveld 408576698