src/v8.gyp - Issue 2061933002: [build] Provide tracing dependency via variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8.gyp

Issue 2061933002: [build] Provide tracing dependency via variable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: patch Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/v8.gyp

diff --git a/src/v8.gyp b/src/v8.gyp

index ec9e6dfab2044a8192083c9f00c9bfb0a97d779d..c5207f99100e947aadd72a9b357720b40d952ed9 100644

--- a/src/v8.gyp

+++ b/src/v8.gyp

@@ -387,8 +387,9 @@

'include_dirs+': [

'..',

- # To be able to find base/trace_event/common/trace_event_common.h

+ # TODO: remove once chromium defines v8_tracing_include_dir

'../..',

+ '<(v8_tracing_include_dir)',

Michael Achenbach 2016/06/15 06:42:43 Won't that fail if you declare just in the standal

Mircea Trofin 2016/06/15 06:45:53 No, I left the ../.. Under the Todo. I like your i

'sources': [ ### gcmole(all) ###

'../include/v8-debug.h',

« no previous file with comments | « gypfiles/standalone.gypi ('k') | no next file » | no next file with comments »