LayoutTests/editing/execCommand/insert-ordered-list-crash.html - Issue 206193003: Clean up a crash test case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/execCommand/insert-ordered-list-crash.html

Issue 206193003: Clean up a crash test case. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/editing/execCommand/insert-ordered-list-crash.html

diff --git a/LayoutTests/editing/execCommand/insert-ordered-list-crash.html b/LayoutTests/editing/execCommand/insert-ordered-list-crash.html

index 49a9159a5535f5441eca6a66dc5c7ff5b916beed..70bfb23137a0034d939a9ba9acc8ed6f6a801311 100644

--- a/LayoutTests/editing/execCommand/insert-ordered-list-crash.html

+++ b/LayoutTests/editing/execCommand/insert-ordered-list-crash.html

@@ -1,39 +1,27 @@

<!DOCTYPE html>

<html>

<head>

- <title>Crash issue 344280</title>

+ <title>Issue 344280</title>

</head>

<body>

description('Should not crash if we load a test case from crbug.com/344280.');

window.jsTestIsAsync = true;

- document.addEventListener("DOMContentLoaded", function () {

- document.execCommand("SelectAll", false);

- window.getSelection().deleteFromDocument();

- }, true);

+ window.addEventListener('message', didReceiveMessage, false);

+ var iframe = document.createElement('iframe');

+ iframe.src = 'resources/insert-ordered-list-crash-iframe.html';

+ document.body.appendChild(iframe);

- var count = 0;

- document.addEventListener("DOMSubtreeModified", function () {

- count++;

- if (count < 3) {

- var src = event.srcElement;

- src.contentEditable = "true";

- src.innerHTML = '<div></div>';

- document.execCommand('InsertOrderedList', false, false);

- } else if (count == 3) {

- window.finishJSTest();

- }

- }, false);

+ function didReceiveMessage(event) {

+ shouldBeEqualToString('event.data', 'FINISH');

+ document.body.removeChild(iframe);

+ testPassed('Did not crash.');

+ window.finishJSTest();

+ }

</script>

- <h5>

- aa

- <textarea></textarea>

- </h5>

- <dl>

- aa

- </dl>

</body>

</html>

« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/insert-ordered-list-crash-expected.txt » ('j') | no next file with comments »