Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
index 78f901fbc694567961f5f4db146ac23691d5323b..ed0587de6a5559144afb5816b7239034db544879 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
@@ -1832,8 +1832,7 @@ class JavaScriptBackend extends Backend {
} else if (cls == noThrowsClass) {
hasNoThrows = true;
if (!Elements.isStaticOrTopLevelFunction(element)) {
- compiler.internalErrorOnElement(
- element,
+ compiler.internalError(element,
"@NoThrows() is currently limited to top-level"
" or static functions");
}
@@ -1850,12 +1849,12 @@ class JavaScriptBackend extends Backend {
}
}
if (hasNoThrows && !hasNoInline) {
- compiler.internalErrorOnElement(
- element, "@NoThrows() should always be combined with @NoInline");
+ compiler.internalError(element,
+ "@NoThrows() should always be combined with @NoInline.");
}
if (hasNoSideEffects && !hasNoInline) {
- compiler.internalErrorOnElement(
- element, "@NoSideEffects() should always be combined with @NoInline");
+ compiler.internalError(element,
+ "@NoSideEffects() should always be combined with @NoInline.");
}
}

Powered by Google App Engine
This is Rietveld 408576698