Fix default category filter for tracing

Fix default category filter for tracing

*Debug and *Test are no longer valid. This CL removes them
and add more tests.

Doc: https://docs.google.com/document/d/1yhQ0wYWIhbYcABTkP3-jKZmRaAN-q3-kji8wWFlkEBc/edit?usp=sharing
Committed: https://crrev.com/66fae9b59da0d84e01804903d2f4ae5d8656f24c
Cr-Commit-Position: refs/heads/master@{#400192}

[Zhen Wang, 2016-06-13 21:21:53]

Description was changed from

==========
Fix default category filter for tracing


Doc:
https://docs.google.com/document/d/1yhQ0wYWIhbYcABTkP3-jKZmRaAN-q3-kji8wWFlkE...
==========

to

==========
Fix default category filter for tracing

*Debug and *Test are no longer valid. This CL removes them
and add more tests.

Doc:
https://docs.google.com/document/d/1yhQ0wYWIhbYcABTkP3-jKZmRaAN-q3-kji8wWFlkE...
==========

[Zhen Wang, 2016-06-13 21:25:13]

zhenw@chromium.org changed reviewers:
+ oysteine@chromium.org, primiano@chromium.org

[Zhen Wang, 2016-06-13 21:25:14]

ptal

[Primiano Tucci (use gerrit), 2016-06-14 15:13:03]

LGTM. Interestingly TIL that "*" does not include "disabled-by-default-*"

https://codereview.chromium.org/2061923002/diff/1/base/trace_event/trace_conf...
File base/trace_event/trace_config.h (right):

https://codereview.chromium.org/2061923002/diff/1/base/trace_event/trace_conf...
base/trace_event/trace_config.h:258: // Returns true if the category is enable
according to this trace config.
since you are touching this line: s/enable/enabled/ :)

https://codereview.chromium.org/2061923002/diff/1/base/trace_event/trace_conf...
base/trace_event/trace_config.h:259: // This is only used internally. Please
refer to IsCategoryGroupEnabled()
Well it's not that this is internal. It's more that this tells whether a
category is enabled from the traceconfig perspective.
THe other in TraceLog tells whether the category is enabled from the tracing
runtime perspective.
The real problem here is that some of the logic (the *) happens only in the
TraceLog

[Zhen Wang, 2016-06-14 20:55:08]

https://codereview.chromium.org/2061923002/diff/1/base/trace_event/trace_conf...
File base/trace_event/trace_config.h (right):

https://codereview.chromium.org/2061923002/diff/1/base/trace_event/trace_conf...
base/trace_event/trace_config.h:258: // Returns true if the category is enable
according to this trace config.
On 2016/06/14 15:13:03, Primiano Tucci wrote:
> since you are touching this line: s/enable/enabled/ :)

Done.

https://codereview.chromium.org/2061923002/diff/1/base/trace_event/trace_conf...
base/trace_event/trace_config.h:259: // This is only used internally. Please
refer to IsCategoryGroupEnabled()
On 2016/06/14 15:13:02, Primiano Tucci wrote:
> Well it's not that this is internal. It's more that this tells whether a
> category is enabled from the traceconfig perspective.
> THe other in TraceLog tells whether the category is enabled from the tracing
> runtime perspective.
> The real problem here is that some of the logic (the *) happens only in the
> TraceLog

Updated.

[Zhen Wang, 2016-06-14 20:55:35]

The CQ bit was checked by zhenw@chromium.org

[Zhen Wang, 2016-06-14 20:55:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2061923002/#ps20001
(title: "review fix and fix test")

[commit-bot: I haz the power, 2016-06-14 20:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061923002/20001

[commit-bot: I haz the power, 2016-06-14 22:55:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 22:55:28]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[Zhen Wang, 2016-06-15 17:02:15]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-06-15 17:02:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061923002/20001

[Zhen Wang, 2016-06-15 17:05:49]

The CQ bit was unchecked by zhenw@chromium.org

[Zhen Wang, 2016-06-15 18:00:24]

Added more tests.

https://codereview.chromium.org/2061923002/diff/40001/base/trace_event/trace_...
File base/trace_event/trace_config_unittest.cc (right):

https://codereview.chromium.org/2061923002/diff/40001/base/trace_event/trace_...
base/trace_event/trace_config_unittest.cc:333: // are also enabled.
This is surprising to me. I thought only the disabled-by-default-foo would be
enabled. But now I think it again, I guess it makes sense to always enable the
default ones if none is specified.

[Zhen Wang, 2016-06-16 15:49:24]

The CQ bit was checked by zhenw@chromium.org

[Zhen Wang, 2016-06-16 15:49:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2061923002/#ps40001
(title: "add more tests")

[commit-bot: I haz the power, 2016-06-16 15:49:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061923002/40001

[commit-bot: I haz the power, 2016-06-16 17:42:52]

Description was changed from

==========
Fix default category filter for tracing

*Debug and *Test are no longer valid. This CL removes them
and add more tests.

Doc:
https://docs.google.com/document/d/1yhQ0wYWIhbYcABTkP3-jKZmRaAN-q3-kji8wWFlkE...
==========

to

==========
Fix default category filter for tracing

*Debug and *Test are no longer valid. This CL removes them
and add more tests.

Doc:
https://docs.google.com/document/d/1yhQ0wYWIhbYcABTkP3-jKZmRaAN-q3-kji8wWFlkE...
==========

[commit-bot: I haz the power, 2016-06-16 17:42:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-16 17:44:33]

Description was changed from

==========
Fix default category filter for tracing

*Debug and *Test are no longer valid. This CL removes them
and add more tests.

Doc:
https://docs.google.com/document/d/1yhQ0wYWIhbYcABTkP3-jKZmRaAN-q3-kji8wWFlkE...
==========

to

==========
Fix default category filter for tracing

*Debug and *Test are no longer valid. This CL removes them
and add more tests.

Doc:
https://docs.google.com/document/d/1yhQ0wYWIhbYcABTkP3-jKZmRaAN-q3-kji8wWFlkE...
Committed: https://crrev.com/66fae9b59da0d84e01804903d2f4ae5d8656f24c
Cr-Commit-Position: refs/heads/master@{#400192}
==========

[commit-bot: I haz the power, 2016-06-16 17:44:34]

Patchset 3 (id:??) landed as
https://crrev.com/66fae9b59da0d84e01804903d2f4ae5d8656f24c
Cr-Commit-Position: refs/heads/master@{#400192}