Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4268)

Unified Diff: mojo/edk/system/dispatcher.h

Issue 2061913002: Don't call the other wait set impl dispatcher methods under mutex either. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/edk/system/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/dispatcher.h
diff --git a/mojo/edk/system/dispatcher.h b/mojo/edk/system/dispatcher.h
index d9fb416d8faf80b5121873c5c5d5df538bc9151f..84df4e42fb43830095ab44fcfd7b666ed42a3aca 100644
--- a/mojo/edk/system/dispatcher.h
+++ b/mojo/edk/system/dispatcher.h
@@ -364,17 +364,16 @@ class Dispatcher : public util::RefCountedThreadSafe<Dispatcher> {
MojoMapBufferFlags flags,
std::unique_ptr<platform::PlatformSharedBufferMapping>* mapping)
MOJO_EXCLUSIVE_LOCKS_REQUIRED(mutex_);
- virtual MojoResult WaitSetAddImplNoLock(
+ // WARNING: Unlike the others, the following wait set methods are *not* called
+ // under |mutex_| and |is_closed_| is *not* checked. Thus any override must
+ // lock |mutex()| and check |is_closed_no_lock()| (returning
+ // |MOJO_RESULT_INVALID_ARGUMENT| if it is true).
+ virtual MojoResult WaitSetAddImpl(
UserPointer<const MojoWaitSetAddOptions> options,
Handle&& handle,
MojoHandleSignals signals,
- uint64_t cookie) MOJO_EXCLUSIVE_LOCKS_REQUIRED(mutex_);
- virtual MojoResult WaitSetRemoveImplNoLock(uint64_t cookie)
- MOJO_EXCLUSIVE_LOCKS_REQUIRED(mutex_);
- // WARNING: Unlike the others, this method is *not* called under |mutex_| and
- // |is_closed_| is *not* checked. Thus any override must lock |mutex()| and
- // check |is_closed_no_lock()| (returning |MOJO_RESULT_INVALID_ARGUMENT| if it
- // is true).
+ uint64_t cookie);
+ virtual MojoResult WaitSetRemoveImpl(uint64_t cookie);
virtual MojoResult WaitSetWaitImpl(MojoDeadline deadline,
UserPointer<uint32_t> num_results,
UserPointer<MojoWaitSetResult> results,
« no previous file with comments | « no previous file | mojo/edk/system/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698