Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2061913002: Don't call the other wait set impl dispatcher methods under mutex either. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't call the other wait set impl dispatcher methods under mutex either. Previously, I only did this for WaitSetWaitImpl(). But then I realized that WaitSetAddImpl() and WaitSetRemoveImpl() also need to deal with the mutex carefully (i.e., not do everything under the mutex) since I need to avoid calling other dispatchers' AddAwakable()/RemoveAwakable() under the mutex. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/1f06dce1f391be3e823d598a502ae7d047ec6ff7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -43 lines) Patch
M mojo/edk/system/dispatcher.h View 1 chunk +7 lines, -8 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 3 chunks +15 lines, -25 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.h View 1 chunk +5 lines, -6 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-13 21:19:35 UTC) #1
vardhan
lgtm
4 years, 6 months ago (2016-06-14 17:03:47 UTC) #2
viettrungluu
4 years, 6 months ago (2016-06-14 17:21:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f06dce1f391be3e823d598a502ae7d047ec6ff7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698