Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 2061903002: Use ThreadTaskRunnerHandle instead of MessageLoop::current() in base/. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, chirantan+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ThreadTaskRunnerHandle instead of MessageLoop::current() in base/. This CL replaces some uses of MessageLoop::current() with ThreadTaskRunnerHandle in base/. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop but they will be able to get the current ThreadTaskRunnerHandle. BUG=616447 Committed: https://crrev.com/270460f567927f16ea93741f28088a433280bc8c Cr-Commit-Position: refs/heads/master@{#399711}

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR danakj #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M base/process/kill_win.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/timer/timer_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-13 21:16:19 UTC) #2
danakj
LGTM https://codereview.chromium.org/2061903002/diff/1/base/process/kill_win.cc File base/process/kill_win.cc (right): https://codereview.chromium.org/2061903002/diff/1/base/process/kill_win.cc#newcode49 base/process/kill_win.cc:49: // win::ObjectWatcher::Delegate --------------------------------------------- Heh this is a weird ...
4 years, 6 months ago (2016-06-13 21:21:13 UTC) #3
fdoray
https://codereview.chromium.org/2061903002/diff/1/base/process/kill_win.cc File base/process/kill_win.cc (right): https://codereview.chromium.org/2061903002/diff/1/base/process/kill_win.cc#newcode49 base/process/kill_win.cc:49: // win::ObjectWatcher::Delegate --------------------------------------------- On 2016/06/13 21:21:12, danakj wrote: > ...
4 years, 6 months ago (2016-06-14 14:01:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061903002/20001
4 years, 6 months ago (2016-06-14 14:02:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 15:21:44 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 15:52:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/270460f567927f16ea93741f28088a433280bc8c
Cr-Commit-Position: refs/heads/master@{#399711}

Powered by Google App Engine
This is Rietveld 408576698