scripts/slave/recipe_modules/chromium_tests/api.py - Issue 2061893003: Build delegation for perf tryjobs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 2061893003: Build delegation for perf tryjobs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Refine request build procedures Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium_tests/api.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py

index 3fde2b046d38c56b427752a299f568288aa8b2d4..57f226c3ca7756a28b7a0916f20ac0c1e91a9cc5 100644

--- a/scripts/slave/recipe_modules/chromium_tests/api.py

+++ b/scripts/slave/recipe_modules/chromium_tests/api.py

@@ -504,9 +504,9 @@ class ChromiumTestsApi(recipe_api.RecipeApi):

self.m.chromium.c.build_dir.join(self.m.chromium.c.build_config_fs))

legacy_build_url = None

- got_revision = update_step.presentation.properties['got_revision']

build_revision = build_revision or self.m.properties.get(

- 'parent_got_revision') or got_revision

+ 'parent_got_revision') or update_step.presentation.properties[

RobertoCN 2016/06/24 18:46:37 This change is ok, but doesn't belong in this cl.

Ziqi Xiong 2016/06/27 18:47:55 Acknowledged.

+ 'got_revision']

build_archive_url = build_archive_url or self.m.properties.get(

'parent_build_archive_url')

if build_archive_url is None: