Build delegation for perf tryjobs

scripts/slave/recipe_modules/perf_try/build_state.py

+"""
+  Most code in this class are copied or adapted from revision_state in
+  auto_bisect module. Future refactoring is needed.
+"""
+
+import json
+
+class BuildState(object):
+
+  SUCCESS, WARNINGS, FAILURE, SKIPPED, EXCEPTION = range(5)
+
+  def __init__(self, api, commit_hash, with_patch):
+    super(BuildState, self).__init__()
+    self.api = api
+    self.commit_hash = str(commit_hash)
+    self.build_archived = False
+    self.build_id = None
+    if with_patch:
+      self.bucket = 'chrome-perf-tryjob'
+    else:
+      self.bucket = 'chrome-perf'
+    self.build_file_path = self._get_build_file_path(commit_hash)
+
+  def _get_build_file_path(self, commit_hash):
+    revision_suffix = '%s.zip' % commit_hash
+    return self._get_platform_gs_prefix() + revision_suffix
+
+  def _get_platform_gs_prefix(self):
+    bot_name = self.api.m.properties.get('buildername', '')
+    if 'win' in bot_name:
+      if any(b in bot_name for b in ['x64', 'gpu']):
+        return 'gs://%s/Win x64 Builder/full-build-win32_' % self.bucket
+      return 'gs://%s/Win Builder/full-build-win32_' % self.bucket
+    if 'android' in bot_name:
+      if 'nexus9' in bot_name:
+        return 'gs://%s/android_perf_rel_arm64/full-build-linux_' % self.bucket
+      return 'gs://%s/android_perf_rel/full-build-linux_' % self.bucket
+    if 'mac' in bot_name:
+      return 'gs://%s/Mac Builder/full-build-mac_' % self.bucket
+    return 'gs://%s/Linux Builder/full-build-linux' % self.bucket
+
+
+  def is_completed(self):
+    result = self.api.m.buildbucket.get_build(self.build_id)
+    return result.stdout['status'] == 'COMPLETED'
+
+  def is_build_archived(self):

[RobertoCN, 2016/06/21 22:39:43]

Maybe merge is_build_archived and is_completed?

[Ziqi Xiong, 2016/06/22 21:41:25]

I am not exactly sure why they should be merged. is_completed checks status
while is_build_archived checks result. They are also used differently. The
former is called in _wait_for, the latter in _download_build

+    result = self.api.m.buildbucket.get_build(self.build_id)
+    self.build_archived =  result.stdout['result'] == 'SUCCESS'
+    return self.build_archived