Build delegation for perf tryjobs

scripts/slave/recipe_modules/perf_try/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """API for the perf try job recipe module.
 
 This API is meant to enable the perf try job recipe on any chromium-supported
 platform for any test that can be run via buildbot, perf or otherwise.
 """
 
 import re
 import urllib
+import uuid
 
 from recipe_engine import recipe_api
+from . import build_state
 
 PERF_CONFIG_FILE = 'tools/run-perf-test.cfg'
 WEBKIT_PERF_CONFIG_FILE = 'third_party/WebKit/Tools/run-perf-test.cfg'
 PERF_BENCHMARKS_PATH = 'tools/perf/benchmarks'
 PERF_MEASUREMENTS_PATH = 'tools/perf/measurements'
 BUILDBOT_BUILDERNAME = 'BUILDBOT_BUILDERNAME'
 BENCHMARKS_JSON_FILE = 'benchmarks.json'
 
 CLOUD_RESULTS_LINK = (r'\s(?P<VALUES>http://storage.googleapis.com/'
                       'chromium-telemetry/html-results/results-[a-z0-9-_]+)\s')
 PROFILER_RESULTS_LINK = (r'\s(?P<VALUES>https://console.developers.google.com/'
                          'm/cloudstorage/b/[a-z-]+/o/profiler-[a-z0-9-_.]+)\s')
 RESULTS_BANNER = """
 ===== PERF TRY JOB RESULTS =====
 
 Test Command: %(command)s
 Test Metric: %(metric)s
 Relative Change: %(relative_change).05f%%
 Standard Error: +- %(std_err).05f delta
 
 %(results)s
 """
-
+SERVICE_ACCOUNT = 'chromium_bisect'
 
 class PerfTryJobApi(recipe_api.RecipeApi):
 
   def __init__(self, *args, **kwargs):
     super(PerfTryJobApi, self).__init__(*args, **kwargs)
 
   def start_perf_try_job(self, affected_files, bot_update_step, bot_db):
     """Entry point pert tryjob or CQ tryjob."""
     perf_config = self._get_perf_config(affected_files)
     if perf_config:
@@ skipping 161 matching lines @@
       overall_success = all(v == 0 for v in retcodes)
     return {
         'results': all_values,
         'ret_code': overall_success,
         'output': ''.join(overall_output)
     }
 
   def _build_and_run_tests(self, cfg, update_step, bot_db, revision,
                            **kwargs):
     """Compiles binaries and runs tests for a given a revision."""
+    with_patch = kwargs.get('name') == 'With Patch'
     update_step = self._checkout_revision(update_step, bot_db, revision)
-    self._compile(kwargs['name'], self.m.properties['mastername'],
-                  self.m.properties['buildername'], update_step, bot_db)
-
+    revision = build_state.BuildState(self, revision, with_patch)
+    self._request_build(revision)
+    self._wait_for(revision)
+    self._download_build(update_step, bot_db, revision)

[prasadv, 2016/06/21 22:32:56]

Also in the test expectation files, I don't see lines 226-230 being executed.

[RobertoCN, 2016/06/21 22:39:43]

It doesn't seem from the expectations that we are getting to this point.

     if self.m.chromium.c.TARGET_PLATFORM == 'android':
       self.m.chromium_android.adb_install_apk('ChromePublic.apk')
 
     return self._run_test(cfg, **kwargs)
 
+  # Duplicate code from auto_bisect.revision_state._request_build
+  def _request_build(self, revision):
+    bot_name = self.get_builder_bot_for_this_platform()
+    build_details = {
+      'bucket': 'master.' + self.m.properties['mastername'],
+      'parameters': {
+        'buildername': bot_name,
+        'properties': {
+          'parent_got_revision': revision.commit_hash,

[prasadv, 2016/06/21 22:32:56]

How the builder know what to patch. Since we are just passing the revision hash
and there is no way the builder can build the revision with patch.

[Ziqi Xiong, 2016/06/22 21:41:25]

Done.

+          'clobber': True,
+          'build_archive_url': revision.build_file_path
+        }
+      },
+      'client_operation_id': uuid.uuid4().hex,
+      'tags':{}
+    }
+    result = self.m.buildbucket.put(
+      [build_details],
+      self.m.service_account.get_json_path(SERVICE_ACCOUNT))
+    revision.build_id = result.stdout['results'][0]['build']['id']
+
+
+  def _wait_for(self, revision):
+    while True:
+      if revision.is_completed():
+        break
+      else:
+        self.m.python.inline(
+            'sleeping',
+            """
+            import sys
+            import time
+            time.sleep(20*60)
+            sys.exit(0)
+            """)
+
+  # Duplicate code from auto_bisect.api.start_test_run_for_bisect
+  def _download_build(self, update_step, bot_db,
+                     revision, run_locally=False,
+                     skip_download=False):
+    if not revision.build_archived:

[RobertoCN, 2016/06/21 22:39:43]

This should be set by build_state.is_build_archived(), but I don't see where
this is called.

[prasadv, 2016/06/21 23:11:04]

This is the reason why we are not able to get other steps in simulation.

[Ziqi Xiong, 2016/06/22 21:41:25]

Done.

[Ziqi Xiong, 2016/06/22 21:41:25]

Done.

+        raise self.m.step.StepFailure('Build %s fails' % revision.build_id)
+    mastername = self.m.properties.get('mastername')
+    buildername = self.m.properties.get('buildername')
+    bot_config = bot_db.get_bot_config(mastername, buildername)
+    build_archive_url = revision.build_file_path
+    if not skip_download:
+      if self.m.chromium.c.TARGET_PLATFORM == 'android':
+        # The best way to ensure the old build directory is not used is to
+        # remove it.
+        build_dir = self.m.chromium.c.build_dir.join(
+            self.m.chromium.c.build_config_fs)
+        self.m.file.rmtree('build directory', build_dir)
+
+        # The way android builders on tryserver.chromium.perf are archived is
+        # different from builders on chromium.perf. In order to support both
+        # forms of archives, we added this temporary hack until builders are
+        # fixed. See http://crbug.com/535218.
+        zip_dir = self.m.path.join(self.m.path['checkout'], 'full-build-linux')
+        if self.m.path.exists(zip_dir):  # pragma: no cover
+          self.m.file.rmtree('full-build-linux directory', zip_dir)
+        gs_bucket = 'gs://%s/' % revision.bucket
+        archive_path = build_archive_url[len(gs_bucket):]
+        self.m.chromium_android.download_build(
+            bucket=bot_config['bucket'],
+            path=archive_path)
+
+        # The way android builders on tryserver.chromium.perf are archived is
+        # different from builders on chromium.perf. In order to support both
+        # forms of archives, we added this temporary hack until builders are
+        # fixed. See http://crbug.com/535218.
+        if self.m.path.exists(zip_dir):  # pragma: no cover
+          self.m.python.inline(
+              'moving full-build-linux to out/Release',
+              """
+              import shutil
+              import sys
+              shutil.move(sys.argv[1], sys.argv[2])
+              """,
+              args=[zip_dir, build_dir])
+      else:
+        self.m.chromium_tests.download_and_unzip_build(
+            mastername, buildername, update_step, bot_db,
+            build_archive_url=build_archive_url,
+            build_revision=revision.commit_hash,
+            override_bot_type='tester')
+
+  # Duplicate code from auto_bisect.bisector.get_builder_bot_for_this_platform
+  def get_builder_bot_for_this_platform(self):
+    bot_name = self.m.properties.get('buildername', '')
+    if 'win' in bot_name:
+      if any(b in bot_name for b in ['x64', 'gpu']):
+        return 'winx64_bisect_builder'
+      return 'win_perf_bisect_builder'
+
+    if 'android' in bot_name:
+      if 'nexus9' in bot_name:
+        return 'android_arm64_perf_bisect_builder'
+      return 'android_perf_bisect_builder'
+
+    if 'mac' in bot_name:
+      return 'mac_perf_bisect_builder'
+
+    return 'linux_perf_bisect_builder'
+
   def _load_config_file(self, name, src_path, **kwargs):
     """Attempts to load the specified config file and grab config dict."""
     step_result = self.m.python(
         name,
         self.resource('load_config_to_json.py'),
         ['--source', src_path, '--output_json', self.m.json.output()],
         **kwargs)
     if not step_result.json.output:  # pragma: no cover
       raise self.m.step.StepFailure('Loading config file failed. [%s]' %
                                     src_path)
@@ skipping 273 matching lines @@
 
 def _prepend_src_to_path_in_command(test_cfg):
   command_to_run = []
   for v in test_cfg.get('command').split():
     if v in ['./tools/perf/run_benchmark',
              'tools/perf/run_benchmark',
              'tools\\perf\\run_benchmark']:
       v = 'src/tools/perf/run_benchmark'
     command_to_run.append(v)
   test_cfg.update({'command': ' '.join(command_to_run)})