Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2061893002: Detect MIPS64 hosts as "mips" architecture (Closed)

Created:
4 years, 6 months ago by brendan.kirby
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, gordana.cmiljanovic, gordanac
CC:
chromium-reviews, akos.palfi.imgtec, gergely.kis.imgtec, petar.jovanovic
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Detect MIPS64 hosts as "mips" architecture OCTEON II boards like the Edge Router Pro are actually MIPS64 processors. So, platform.machine() reports them as "mips64". BUG= Committed: https://crrev.com/a321aeb2364edb926de15e1486d1f98f84d96489 Cr-Commit-Position: refs/heads/master@{#399900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M build/detect_host_arch.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
brendan.kirby
PTAL This fixes gclient runhooks failures on MIPS64 boards like the OCTEON II based Edge ...
4 years, 6 months ago (2016-06-13 21:01:59 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-14 20:35:33 UTC) #3
gordanac
lgtm, though OWNER's approval is sufficient.
4 years, 6 months ago (2016-06-15 10:33:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061893002/1
4 years, 6 months ago (2016-06-15 14:53:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 15:48:19 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 15:48:23 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 15:49:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a321aeb2364edb926de15e1486d1f98f84d96489
Cr-Commit-Position: refs/heads/master@{#399900}

Powered by Google App Engine
This is Rietveld 408576698