third_party/WebKit/Source/core/fetch/Resource.cpp - Issue 2061843002: CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer, not equal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 2061843002: CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer, not equal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove some cruft from the test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/fetch/Resource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp

index f043b1bc93af6415e8a3f76d5950742a1286fdb4..c481de075a3582a3b8c47d10158a998684da6045 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.cpp

+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp

@@ -898,7 +898,7 @@ String Resource::getMemoryDumpName() const

void Resource::revalidationSucceeded(const ResourceResponse& validatingResponse)

{

SECURITY_CHECK(m_redirectChain.isEmpty());

- SECURITY_CHECK(validatingResponse.url() == m_response.url());

+ SECURITY_CHECK(equalIgnoringFragmentIdentifier(validatingResponse.url(), m_response.url()));

m_response.setResourceLoadTiming(validatingResponse.resourceLoadTiming());

// RFC2616 10.3.5

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/ResourceTest.cpp » ('j') | third_party/WebKit/Source/core/fetch/ResourceTest.cpp » ('J')