CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer, not equal

CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer, not equal

BUG=618967
TEST=ResourceTest.RevalidateWithFragment

Committed: https://crrev.com/9a5635c505fc5b93036793d5b2abe6793b0c5d80
Cr-Commit-Position: refs/heads/master@{#399589}

[Nate Chapin, 2016-06-13 19:12:14]

Description was changed from

==========
Assert that Resource request/response urls are equalIgnoringFragmentIdentifer,
not equal

BUG=618967
TEST=ResourceTest.RevalidateWithFragment
==========

to

==========
CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer,
not equal

BUG=618967
TEST=ResourceTest.RevalidateWithFragment
==========

[hiroshige, 2016-06-13 20:17:03]

hiroshige@chromium.org changed reviewers:
+ hiroshige@chromium.org

[hiroshige, 2016-06-13 20:17:04]

lgtm, thanks!

https://codereview.chromium.org/2061843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceTest.cpp (right):

https://codereview.chromium.org/2061843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceTest.cpp:115: TEST(ResourceTest,
RevalidateWithFragment)
Could you add a comment about what this is testing (i.e. not crashing due to
assertions)?

[yhirano, 2016-06-13 20:17:14]

yhirano@chromium.org changed reviewers:
+ yhirano@chromium.org
- hiroshige@chromium.org

[yhirano, 2016-06-13 20:17:15]

lgtm

https://codereview.chromium.org/2061843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceTest.cpp (right):

https://codereview.chromium.org/2061843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceTest.cpp:115: TEST(ResourceTest,
RevalidateWithFragment)
Can you write some comments that we don't need ASSERT / EXPECT in this test?

[Nate Chapin, 2016-06-13 20:51:13]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-06-13 20:51:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2061843002/#ps60001
(title: "Add a bit more detail in the comment")

[Nate Chapin, 2016-06-13 20:51:21]

https://codereview.chromium.org/2061843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceTest.cpp (right):

https://codereview.chromium.org/2061843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceTest.cpp:115: TEST(ResourceTest,
RevalidateWithFragment)
On 2016/06/13 20:17:14, yhirano wrote:
> Can you write some comments that we don't need ASSERT / EXPECT in this test?

Done.

[commit-bot: I haz the power, 2016-06-13 20:52:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061843002/60001

[commit-bot: I haz the power, 2016-06-13 22:55:12]

Description was changed from

==========
CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer,
not equal

BUG=618967
TEST=ResourceTest.RevalidateWithFragment
==========

to

==========
CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer,
not equal

BUG=618967
TEST=ResourceTest.RevalidateWithFragment
==========

[commit-bot: I haz the power, 2016-06-13 22:55:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-13 22:55:14]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 22:56:21]

Description was changed from

==========
CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer,
not equal

BUG=618967
TEST=ResourceTest.RevalidateWithFragment
==========

to

==========
CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer,
not equal

BUG=618967
TEST=ResourceTest.RevalidateWithFragment

Committed: https://crrev.com/9a5635c505fc5b93036793d5b2abe6793b0c5d80
Cr-Commit-Position: refs/heads/master@{#399589}
==========

[commit-bot: I haz the power, 2016-06-13 22:56:22]

Patchset 4 (id:??) landed as
https://crrev.com/9a5635c505fc5b93036793d5b2abe6793b0c5d80
Cr-Commit-Position: refs/heads/master@{#399589}