disallow -4 pointer

disallow -4 pointer

A user's homegrown unsigned integer overflow tool
complains if a nullptr is decremented.
The conicWeight pointer likes to predecrement
before walking, but this is unnecessary if
its value is nullptr.

R=reed@google.com
BUG=skia:5415
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061833005

Committed: https://skia.googlesource.com/skia/+/6942442ef7cc018ac136dd379ad6a30902a060e5

[caryclark, 2016-06-14 20:30:22]

Description was changed from

==========
disallow -4 pointer

UBSan complains if a nullptr is decremented.
The conicWeight pointer likes to predecrement
before walking, but this is unnecessary if
its value is nullptr.

R=reed@google.com
BUG=skia:5415
==========

to

==========
disallow -4 pointer

UBSan complains if a nullptr is decremented.
The conicWeight pointer likes to predecrement
before walking, but this is unnecessary if
its value is nullptr.

R=reed@google.com
BUG=skia:5415
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061833005
==========

[caryclark, 2016-06-14 20:31:41]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 20:31:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061833005/1

[caryclark, 2016-06-14 20:35:07]

Description was changed from

==========
disallow -4 pointer

UBSan complains if a nullptr is decremented.
The conicWeight pointer likes to predecrement
before walking, but this is unnecessary if
its value is nullptr.

R=reed@google.com
BUG=skia:5415
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061833005
==========

to

==========
disallow -4 pointer

A user's homegrown unsigned integer overflow tool
complains if a nullptr is decremented.
The conicWeight pointer likes to predecrement
before walking, but this is unnecessary if
its value is nullptr.

R=reed@google.com
BUG=skia:5415
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061833005
==========

[commit-bot: I haz the power, 2016-06-14 21:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 21:37:08]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-06-15 12:51:50]

See the bug for some additional details. I'm undecided on whether this should be
committed or not.

[caryclark, 2016-10-04 19:35:33]

caryclark@google.com changed reviewers:
+ mtklein@google.com

[caryclark, 2016-10-04 19:35:34]

Cleaning up old bugs. The CL is still pending. Do you have an opinion about
whether this is worth fixing or not? The change looks harmless, but I don't know
if this is worth fixing.

Adding mtklein in case he has an opinion.

[mtklein_C, 2016-10-04 19:39:20]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-10-04 19:39:21]

lgtm

[reed1, 2016-10-04 19:42:07]

lgtm

[reed1, 2016-10-04 19:42:13]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-10-04 19:42:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:06:22]

Description was changed from

==========
disallow -4 pointer

A user's homegrown unsigned integer overflow tool
complains if a nullptr is decremented.
The conicWeight pointer likes to predecrement
before walking, but this is unnecessary if
its value is nullptr.

R=reed@google.com
BUG=skia:5415
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061833005
==========

to

==========
disallow -4 pointer

A user's homegrown unsigned integer overflow tool
complains if a nullptr is decremented.
The conicWeight pointer likes to predecrement
before walking, but this is unnecessary if
its value is nullptr.

R=reed@google.com
BUG=skia:5415
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061833005

Committed:
https://skia.googlesource.com/skia/+/6942442ef7cc018ac136dd379ad6a30902a060e5
==========

[commit-bot: I haz the power, 2016-10-04 20:06:24]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6942442ef7cc018ac136dd379ad6a30902a060e5