Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2061833003:
[wasm] Support for memory size relocation for asm-wasm. (Closed)
|
Created:
4 years, 6 months ago by Mircea Trofin Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] Support for memory size relocation for asm-wasm.
Only Intel needed changes, arm and mips work as expected.
BUG=
Committed: https://crrev.com/c5e3c9bf5661c519e36e34493b5625f6c5614c36
Cr-Commit-Position: refs/heads/master@{#37011}
Patch Set 1 #Patch Set 2 #
Messages
Total messages: 27 (13 generated)
Description was changed from ========== [wasm] Globals are relocatable, and support for relocation for asm-wasm. BUG= ========== to ========== [wasm] Support for memory size relocation for asm-wasm. Only Intel needed changes, arm and mips work as expected. BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org
The CQ bit was checked by bradnelson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061833003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17236)
mtrofin@chromium.org changed reviewers: + dehrenberg@chromium.org, titzer@chromium.org
owners issue again... Thanks!
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061833003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061833003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17245)
mtrofin@chromium.org changed reviewers: + bmeurer@chromium.org, jarin@chromium.org - dehrenberg@chromium.org, littledan@chromium.org
Benedikt, Jaroslav - could you please take a look at this CL? Thanks!
lgtm
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061833003/20001
Message was sent while issue was closed.
Description was changed from ========== [wasm] Support for memory size relocation for asm-wasm. Only Intel needed changes, arm and mips work as expected. BUG= ========== to ========== [wasm] Support for memory size relocation for asm-wasm. Only Intel needed changes, arm and mips work as expected. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Support for memory size relocation for asm-wasm. Only Intel needed changes, arm and mips work as expected. BUG= ========== to ========== [wasm] Support for memory size relocation for asm-wasm. Only Intel needed changes, arm and mips work as expected. BUG= Committed: https://crrev.com/c5e3c9bf5661c519e36e34493b5625f6c5614c36 Cr-Commit-Position: refs/heads/master@{#37011} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c5e3c9bf5661c519e36e34493b5625f6c5614c36 Cr-Commit-Position: refs/heads/master@{#37011} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
