Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 206183006: ArrayPush builtin handlified. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -34 lines) Patch
M src/builtins.cc View 5 chunks +25 lines, -33 lines 0 comments Download
M src/elements.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/elements.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/factory.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-20 12:04:11 UTC) #1
Yang
On 2014/03/20 12:04:11, Igor Sheludko wrote: > PTAL lgtm.
6 years, 9 months ago (2014-03-20 12:17:21 UTC) #2
Igor Sheludko
6 years, 9 months ago (2014-03-20 13:01:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698