Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 206183005: A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. (Closed)

Created:
6 years, 9 months ago by Alexandre Rames
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. Abstract a register to simplify code generation. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20116

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test after rebasing. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M src/a64/stub-cache-a64.cc View 1 2 chunks +3 lines, -12 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Alexandre Rames
6 years, 9 months ago (2014-03-20 10:38:08 UTC) #1
ulan
https://codereview.chromium.org/206183005/diff/1/src/a64/stub-cache-a64.cc File src/a64/stub-cache-a64.cc (right): https://codereview.chromium.org/206183005/diff/1/src/a64/stub-cache-a64.cc#newcode465 src/a64/stub-cache-a64.cc:465: (FLAG_track_double_fields && representation.IsDouble()) ? storage_reg why FLAG_track_double_fields?
6 years, 9 months ago (2014-03-20 10:39:36 UTC) #2
Alexandre Rames
On 2014/03/20 10:39:36, ulan wrote: > https://codereview.chromium.org/206183005/diff/1/src/a64/stub-cache-a64.cc > File src/a64/stub-cache-a64.cc (right): > > https://codereview.chromium.org/206183005/diff/1/src/a64/stub-cache-a64.cc#newcode465 > ...
6 years, 9 months ago (2014-03-20 10:44:28 UTC) #3
Alexandre Rames
Updated...
6 years, 9 months ago (2014-03-20 10:47:33 UTC) #4
ulan
lgtm https://codereview.chromium.org/206183005/diff/2/src/a64/stub-cache-a64.cc File src/a64/stub-cache-a64.cc (right): https://codereview.chromium.org/206183005/diff/2/src/a64/stub-cache-a64.cc#newcode464 src/a64/stub-cache-a64.cc:464: Register prop_reg = (representation.IsDouble()) ? storage_reg : value_reg; ...
6 years, 9 months ago (2014-03-20 10:49:26 UTC) #5
Alexandre Rames
6 years, 9 months ago (2014-03-20 11:35:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r20116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698