Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2061803002: 📰 The Status card reports disabled sync states (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplifyBridge
Patch Set: yolo: another big bag of changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index 811609db61f3023495825a1dab41b8057c839958..2ece634b09b1e037a72a4b0bdb8b07086a5d5189 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -28,8 +28,8 @@
public interface SnippetsObserver {
void onSnippetsReceived(List<SnippetArticle> snippets);
- /** Called when the service has been disabled. */
- void onSnippetsDisabled();
+ /** Called when the service is about to change its state. */
+ void onDisabledReasonChanged(int disabledReason);
}
/**
@@ -109,6 +109,11 @@ public void setObserver(SnippetsObserver observer) {
nativeSetObserver(mNativeSnippetsBridge, observer == null ? null : this);
}
+ public int getDisabledReason() {
+ assert mNativeSnippetsBridge != 0;
+ return nativeGetDisabledReason(mNativeSnippetsBridge);
+ }
+
@CalledByNative
private void onSnippetsAvailable(String[] ids, String[] titles, String[] urls, String[] ampUrls,
String[] thumbnailUrls, String[] previewText, long[] timestamps, String[] publishers,
@@ -126,8 +131,8 @@ private void onSnippetsAvailable(String[] ids, String[] titles, String[] urls, S
}
@CalledByNative
- private void onSnippetsDisabled() {
- if (mObserver != null) mObserver.onSnippetsDisabled();
+ private void onDisabledReasonChanged(int disabledReason) {
+ if (mObserver != null) mObserver.onDisabledReasonChanged(disabledReason);
}
private native long nativeInit(Profile profile);
@@ -140,4 +145,5 @@ private static native void nativeSnippetVisited(long nativeNTPSnippetsBridge,
Callback<Boolean> callback, String url);
private native void nativeFetchImage(
long nativeNTPSnippetsBridge, String snippetId, Callback<Bitmap> callback);
+ private native int nativeGetDisabledReason(long nativeNTPSnippetsBridge);
}

Powered by Google App Engine
This is Rietveld 408576698