chrome/android/java/res/layout/new_tab_page_status_card.xml - Issue 2061803002: 📰 The Status card reports disabled sync states

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/new_tab_page_status_card.xml

Issue 2061803002: 📰 The Status card reports disabled sync states (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplifyBridge

Patch Set: [NTP Snippets] The Status card reports disabled sync states Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/new_tab_page_status_card.xml

diff --git a/chrome/android/java/res/layout/new_tab_page_status_card.xml b/chrome/android/java/res/layout/new_tab_page_status_card.xml

index b7a00c4fac09eacb93513d63b16be9a7d3b96c31..993b05ab2b4871a1c1cc40ea54c00272f1e295f4 100644

--- a/chrome/android/java/res/layout/new_tab_page_status_card.xml

+++ b/chrome/android/java/res/layout/new_tab_page_status_card.xml

@@ -15,8 +15,7 @@

android:background="@color/snippets_background_color">

<org.chromium.ui.widget.TextViewWithLeading

- android:id="@+id/status_headline"

- android:text="@string/ntp_status_card_title_empty"

+ android:id="@+id/status_title"

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:textSize="16sp"

@@ -24,8 +23,7 @@

chrome:leading="24dp" />

<org.chromium.ui.widget.TextViewWithLeading

- android:id="@+id/status_snippet"

- android:text="@string/ntp_status_card_body_empty"

+ android:id="@+id/status_body"

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:layout_marginTop="8dp"

@@ -37,12 +35,11 @@

supposed to have 8dp margin while we have a 16dp margin at the parent

level. -->

<Button

- android:id="@+id/reload_button"

+ android:id="@+id/status_action_button"

style="@style/ButtonCompatBorderless"

android:layout_marginEnd="-8dp"

android:layout_width="wrap_content"

android:layout_height="wrap_content"

- android:text="@string/reload"

android:textAllCaps="true"

android:textColor="@color/light_active_color"

android:textSize="15sp" />