chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 2061803002: 📰 The Status card reports disabled sync states

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2061803002: 📰 The Status card reports disabled sync states (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplifyBridge

Patch Set: Refactor out status detection, update tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | components/ntp_snippets/ntp_snippets_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index 1400e057e8bb06ebb51c986eaf21ff2f9c2c00bf..5e514664566193a05edfeda91db2b6fe9ced2d3d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -145,11 +145,14 @@

void navigateToRecentTabs();

/**

- * Opens an url in the current tab.

+ * Opens an url in the current tab and records related metrics.

* @param url the URL to open

void openSnippet(String url);

+ /** Opens a url in the current tab. */

+ void openUrl(String url);

/** Opens the interests dialog. */

void navigateToInterests();