Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: components/ntp_snippets/ntp_snippets_fetcher.h

Issue 2061803002: 📰 The Status card reports disabled sync states (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplifyBridge
Patch Set: Refactor out status detection, update tests. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_FETCHER_H_ 5 #ifndef COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_FETCHER_H_
6 #define COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_FETCHER_H_ 6 #define COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_FETCHER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 // Does the fetcher use host restrictions? 108 // Does the fetcher use host restrictions?
109 bool UsesHostRestrictions() const; 109 bool UsesHostRestrictions() const;
110 // Does the fetcher use authentication to get personalized results? 110 // Does the fetcher use authentication to get personalized results?
111 bool UsesAuthentication() const; 111 bool UsesAuthentication() const;
112 112
113 // Overrides internal clock for testing purposes. 113 // Overrides internal clock for testing purposes.
114 void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock) { 114 void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock) {
115 tick_clock_ = std::move(tick_clock); 115 tick_clock_ = std::move(tick_clock);
116 } 116 }
117 117
118 void SetPersonalizationForTesting(Personalization personalization) {
119 personalization_ = personalization;
120 }
121
118 private: 122 private:
119 FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest, BuildRequestAuthenticated); 123 FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest, BuildRequestAuthenticated);
120 FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest, BuildRequestUnauthenticated); 124 FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest, BuildRequestUnauthenticated);
121 125
122 static std::string BuildRequest(const std::string& obfuscated_gaia_id, 126 static std::string BuildRequest(const std::string& obfuscated_gaia_id,
123 bool only_return_personalized_results, 127 bool only_return_personalized_results,
124 const std::string& user_segment, 128 const std::string& user_segment,
125 const std::set<std::string>& host_restricts, 129 const std::set<std::string>& host_restricts,
126 int count_to_fetch); 130 int count_to_fetch);
127 131
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 // Allow for an injectable tick clock for testing. 196 // Allow for an injectable tick clock for testing.
193 std::unique_ptr<base::TickClock> tick_clock_; 197 std::unique_ptr<base::TickClock> tick_clock_;
194 198
195 base::WeakPtrFactory<NTPSnippetsFetcher> weak_ptr_factory_; 199 base::WeakPtrFactory<NTPSnippetsFetcher> weak_ptr_factory_;
196 200
197 DISALLOW_COPY_AND_ASSIGN(NTPSnippetsFetcher); 201 DISALLOW_COPY_AND_ASSIGN(NTPSnippetsFetcher);
198 }; 202 };
199 } // namespace ntp_snippets 203 } // namespace ntp_snippets
200 204
201 #endif // COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_FETCHER_H_ 205 #endif // COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_FETCHER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698