Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2061793003: Remove redundant isLayoutSizeChanged check in LayoutSVGText::layout (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant isLayoutSizeChanged check in LayoutSVGText::layout SVGLayoutSupport::layoutChildren takes care to propagate the needs for metrics updates via the |screenScalingFactorChanged| and |layoutSizeChanged| arguments. BUG=603956 Committed: https://crrev.com/6d58939f2253f0686141508c07c666a092e5b2a2 Cr-Commit-Position: refs/heads/master@{#399796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
4 years, 6 months ago (2016-06-14 18:40:53 UTC) #2
Stephen Chennney
lgtm
4 years, 6 months ago (2016-06-14 20:38:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061793003/1
4 years, 6 months ago (2016-06-14 20:48:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 22:11:31 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 22:11:34 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 22:14:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d58939f2253f0686141508c07c666a092e5b2a2
Cr-Commit-Position: refs/heads/master@{#399796}

Powered by Google App Engine
This is Rietveld 408576698