Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 2061773002: Revert of Make chrome/browser and .../ui static libraries. (Closed)

Created:
4 years, 6 months ago by fmeawad
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, dpranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make chrome/browser and .../ui static libraries. (patchset #2 id:20001 of https://codereview.chromium.org/2063483002/ ) Reason for revert: Breaking Win x64 Perf builder (official) Speculative. BUG=619606 Original issue's description: > Make chrome/browser and .../ui static libraries. > > On Windows this seems to make some tests link faster because the tests link to these larget targets but don't use most of them. The static library is much more efficient to link in this case since only the required compilation units are loaded. > > TBR=dpranke > (split off of https://codereview.chromium.org/2043873004/ which already has review) > BUG=617837 > > Committed: https://crrev.com/2f95a3fb1773f911ca05c26cbacaecc537bd9e31 > Cr-Commit-Position: refs/heads/master@{#399401} TBR=dpranke@google.com,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617837 Committed: https://crrev.com/7395734b45799a2bc04f54b8a932db259314faac Cr-Commit-Position: refs/heads/master@{#399462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -22 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fmeawad
Created Revert of Make chrome/browser and .../ui static libraries.
4 years, 6 months ago (2016-06-13 16:01:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061773002/1
4 years, 6 months ago (2016-06-13 16:02:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 16:03:34 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 16:03:36 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7395734b45799a2bc04f54b8a932db259314faac Cr-Commit-Position: refs/heads/master@{#399462}
4 years, 6 months ago (2016-06-13 16:06:02 UTC) #8
Dirk Pranke
4 years, 6 months ago (2016-06-13 16:06:27 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698