Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2061753002: PPC: [builtins] Introduce proper Float64Log1p, Float64Atan and Float64Atan2 operators. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [builtins] Introduce proper Float64Log1p, Float64Atan and Float64Atan2 operators. Port 7ceed92ac036d6b4e402d76a5cea130a3c4cfbf1 Port 89d8c57b9c3b29e7977b13f0a9eed6bd8fb6772d Original commit message: Import base::ieee754::atan() and base::ieee754::atan2() from fdlibm and introduce Float64Atan and Float64Atan2 TurboFan operators based on those, similar to what we already did for Float64Log and Float64Log1p. Rewrite Math.atan() and Math.atan2() as TurboFan builtin and use the operators to also inline Math.atan() and Math.atan2() into optimized TurboFan functions. Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.log1p() as TurboFan builtin and use that operator to also inline Math.log1p() into optimized TurboFan functions. Also unify the handling of the special IEEE 754 functions somewhat in the TurboFan backends. At some point we can hopefully express this completely in the InstructionSelector (once we have an idea what to do with the ST(0) return issue on IA-32/X87). Drive-by-fix: Add some more test coverage for the log function. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5086, v8:5092, v8:5095 LOG=N Committed: https://crrev.com/6203906ccd986150ef9cdfedd285c50edbf1eae2 Cr-Commit-Position: refs/heads/master@{#36935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -21 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +38 lines, -13 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-13 14:45:12 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-13 15:07:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061753002/1
4 years, 6 months ago (2016-06-13 15:07:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 15:30:48 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 15:31:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6203906ccd986150ef9cdfedd285c50edbf1eae2
Cr-Commit-Position: refs/heads/master@{#36935}

Powered by Google App Engine
This is Rietveld 408576698