Returning the closest public superclass rather than returning ""

pkg/docgen/lib/docgen.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * **docgen** is a tool for creating machine readable representations of Dart
  * code metadata, including: classes, members, comments and annotations.
  *
  * docgen is run on a `.dart` file or a directory containing `.dart` files.
  *
@@ skipping 602 matching lines @@
       this.isPrivate = true;
       // Since we are now making the mixin a private class, make all elements 
       // with the mixin as an owner private too. 
       entityMap.values.where((e) => e.owner == qualifiedName)
         .forEach((element) => element.isPrivate = true);
       // Move the subclass up to the next public superclass
       subclasses.forEach((subclass) => addSubclass(entityMap[subclass]));
     }
   }
   
+  /** 
+   * If a class extends a private superclass, find the closest public superclass
+   * of the private superclass. 
+   */
+  String validSuperclass() {
+    if (superclass == null) return "";

[Bob Nystrom, 2013/08/01 23:31:40]

Is there a reason to return "" instead of "Object" here?

[janicejl, 2013/08/02 00:49:09]

Done.

+    else {

[Bob Nystrom, 2013/08/01 23:31:40]

"else" isn't needed here.

[janicejl, 2013/08/02 00:49:09]

Done.

+      if (_filterPrivate(superclass)) return superclass.qualifiedName;

[Bob Nystrom, 2013/08/01 23:31:40]

"filter" is a bit confusing here. I would expect it to return true if superclass
*is* private. How about "_isHidden"?

[janicejl, 2013/08/02 00:49:09]

Done.

+      else return superclass.validSuperclass();

[Bob Nystrom, 2013/08/01 23:31:40]

"else" isn't needed here.

[janicejl, 2013/08/02 00:49:09]

Done.

+    }
+  }
+  
   /// Generates a map describing the [Class] object.
   Map toMap() => {
     'name': name,
     'qualifiedname': qualifiedName,
     'comment': comment,
-    'superclass': superclass == null ? "" : (_filterPrivate(superclass)) ? 
-        superclass.qualifiedName : "",
+    'superclass': validSuperclass(),
     'implements': new List.from(interfaces.where((e) => _filterPrivate(e))
         .map((e) => e.qualifiedName)),
     'subclass': new List.from(subclasses),
     'variables': recurseMap(variables),
     'inheritedvariables': recurseMap(inheritedVariables),
     'methods': methods.toMap(),
     'inheritedmethods': inheritedMethods.toMap(),
     'annotations': new List.from(annotations),
     'generics': recurseMap(generics)
   };
@@ skipping 288 matching lines @@
   String outer;
   List<Type> inner;
   
   Type(this.outer, this.inner);
   
   Map toMap() => {
     'outer': outer,
     'inner': new List.from(inner.map((e) => e.toMap()))
   };
 }