Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2061653002: 📰 Small layout fixes to the cards and header (Closed)

Created:
4 years, 6 months ago by dgn
Modified:
4 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, zine-eng+reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Small layout fixes to the cards and header - Fixed the way the header collapses, it now slides under the top card. https://goo.gl/photos/HvDEupKHb26x7zXW6 - Added space between the text and the button on status cards. https://goo.gl/photos/fkXrg5aTwMc7fWTr8 BUG=617140, 612508 Committed: https://crrev.com/f5356095cd4a7d40ba2bee0facb8d1ca155c778c Cr-Commit-Position: refs/heads/master@{#399436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/res/layout/new_tab_page_snippets_header.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/new_tab_page_status_card.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061653002/1
4 years, 6 months ago (2016-06-13 11:18:36 UTC) #4
dgn
PTAL. Margin on the reload button: https://goo.gl/photos/fkXrg5aTwMc7fWTr8 Changes to the header: https://goo.gl/photos/HvDEupKHb26x7zXW6
4 years, 6 months ago (2016-06-13 11:22:08 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 11:55:03 UTC) #7
Bernhard Bauer
LGTM. On 2016/06/13 11:22:08, dgn wrote: > PTAL. > > Margin on the reload button: ...
4 years, 6 months ago (2016-06-13 12:12:25 UTC) #8
dgn
On 2016/06/13 12:12:25, Bernhard Bauer wrote: > LGTM. > > On 2016/06/13 11:22:08, dgn wrote: ...
4 years, 6 months ago (2016-06-13 12:14:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061653002/1
4 years, 6 months ago (2016-06-13 12:14:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 12:19:45 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 12:19:52 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 12:21:05 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5356095cd4a7d40ba2bee0facb8d1ca155c778c
Cr-Commit-Position: refs/heads/master@{#399436}

Powered by Google App Engine
This is Rietveld 408576698